linux-kernel - Re: [PATCH v12 04/16] x86/mm: get INVLPGB count max from CPUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef1792cc40b5812975008a9646a9ba8f3b432a62.camel@surriel.com>
Date: Thu, 20 Feb 2025 21:25:15 -0500
From: Rik van Riel <riel@...riel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, peterz@...radead.org, 
	dave.hansen@...ux.intel.com, zhengqi.arch@...edance.com,
 nadav.amit@...il.com, 	thomas.lendacky@....com, kernel-team@...a.com,
 linux-mm@...ck.org, 	akpm@...ux-foundation.org, jackmanb@...gle.com,
 jannh@...gle.com, 	mhklinux@...look.com, andrew.cooper3@...rix.com,
 Manali.Shukla@....com, Dave Hansen <dave.hansen@...el.com>
Subject: Re: [PATCH v12 04/16] x86/mm: get INVLPGB count max from CPUID

On Fri, 2025-02-21 at 02:58 +0100, Borislav Petkov wrote:
> On Thu, Feb 20, 2025 at 07:53:03PM -0500, Rik van Riel wrote:
> > diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
> > index 2a7279d80460..bb6943c21b7f 100644
> > --- a/arch/x86/Kconfig.cpu
> > +++ b/arch/x86/Kconfig.cpu
> > @@ -401,6 +401,10 @@ menuconfig PROCESSOR_SELECT
> >  	  This lets you choose what x86 vendor support code your
> > kernel
> >  	  will include.
> >  
> > +config X86_BROADCAST_TLB_FLUSH
> > +	def_bool y
> > +	depends on CPU_SUP_AMD && 64BIT
> > +
> >  config CPU_SUP_INTEL
> >  	default y
> >  	bool "Support Intel processors" if PROCESSOR_SELECT
> > @@ -431,6 +435,7 @@ config CPU_SUP_CYRIX_32
> >  config CPU_SUP_AMD
> >  	default y
> >  	bool "Support AMD processors" if PROCESSOR_SELECT
> > +	select X86_BROADCAST_TLB_FLUSH
> >  	help
> >  	  This enables detection, tunings and quirks for AMD
> > processors
> 
> You missed my comment again. How about you read review feedback more
> carefully
> please?
> 
I try, but most of my brainpower the last round was
spent trying to figure out what to do where you and
Dave both wanted something different :)

> CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on
> CPU_SUP_AMD which
> selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD...

I'll fix that to have it depend only on 64BIT.

-- 
All Rights Reversed.