linux-kernel - Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7fHNEFo7Aa4jfUO@shell.armlinux.org.uk>
Date: Fri, 21 Feb 2025 00:22:12 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jan Petrous <jan.petrous@....nxp.com>, NXP S32 Linux Team <s32@....com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: fix DWMAC S32 entry

On Thu, Feb 20, 2025 at 03:22:48PM -0800, Jakub Kicinski wrote:
> On Tue, 18 Feb 2025 09:23:14 +0000 Russell King (Oracle) wrote:
> > Using L: with more than a bare email address causes getmaintainer.pl
> > to be unable to parse the entry. Fix this by doing as other entries
> > that use this email address and convert it to an R: entry.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > ---
> >  MAINTAINERS | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index de81a3d68396..7da5d2df1b45 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2877,7 +2877,7 @@ F:	drivers/pinctrl/nxp/
> >  
> >  ARM/NXP S32G/S32R DWMAC ETHERNET DRIVER
> >  M:	Jan Petrous <jan.petrous@....nxp.com>
> > -L:	NXP S32 Linux Team <s32@....com>
> > +R:	NXP S32 Linux Team <s32@....com>
> >  S:	Maintained
> 
> I had to look thru old commits, 8b0f64b113d61 specifically.
> Can we also strip the "NXP S32 Linux Team"
> It's pretty obvious from s32@....com that it's a group address,
> and this way our scripts will know that this is not a real reviewer.

Right now, the situation is:

$ grep s32@....com MAINTAINERS
R:      NXP S32 Linux Team <s32@....com>
L:      NXP S32 Linux Team <s32@....com>
R:      NXP S32 Linux Team <s32@....com>
L:      s32@....com

and the approach that has been taken in the past is:

-L:     NXP S32 Linux Team <s32@....com>
+R:     NXP S32 Linux Team <s32@....com>

in commit bb2de9b04942 ("MAINTAINERS: fix list entries with display names")

However, commit 98dcb872779f ("ARM: s32c: update MAINTAINERS entry") did
the reverse for the "ARM/NXP S32G ARCHITECTURE" entry breaking that and
adding a new instance of this breakage elsewhere.

It seems these are just going to flip back and forth, so I don't think
I can be bothered to try to fix it, and will modify my own scripts to
eliminate the blank entry in get_maintainers output because of this.
(In other words, s32@....com will *not* be Cc'd for any patches I send.)


-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!