linux-kernel - Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7jgaL0u8VzN-12X@smile.fi.intel.com>
Date: Fri, 21 Feb 2025 22:22:00 +0200
From: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
To: Aditya Garg <gargaditya08@...e.com>
Cc: "pmladek@...e.com" <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	"linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
	"senozhatsky@...omium.org" <senozhatsky@...omium.org>,
	Jonathan Corbet <corbet@....net>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>,
	"airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"dwaipayanray1@...il.com" <dwaipayanray1@...il.com>,
	"lukas.bulwahn@...il.com" <lukas.bulwahn@...il.com>,
	"sumit.semwal@...aro.org" <sumit.semwal@...aro.org>,
	"christian.koenig@....com" <christian.koenig@....com>,
	Kerem Karabay <kekrby@...il.com>, Aun-Ali Zaidi <admin@...eit.net>,
	Orlando Chamberlain <orlandoch.dev@...il.com>,
	Atharva Tiwari <evepolonium@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	Hector Martin <marcan@...can.st>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>,
	Asahi Linux Mailing List <asahi@...ts.linux.dev>,
	Sven Peter <sven@...npeter.dev>, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v3 2/3] lib/vsprintf: Add support for generic FOURCCs by
 extending %p4cc

On Fri, Feb 21, 2025 at 10:18:16PM +0200, andriy.shevchenko@...ux.intel.com wrote:
> On Fri, Feb 21, 2025 at 07:37:17PM +0000, Aditya Garg wrote:
> > > On 21 Feb 2025, at 8:59 PM, andriy.shevchenko@...ux.intel.com wrote:
> > > On Fri, Feb 21, 2025 at 11:37:13AM +0000, Aditya Garg wrote:
> 
> > > First of all, I do not see the cover letter. Is it only an issue on my side?
> > 
> > These are literally 3 patches that are self explanatory.
> 
> So what? Anybody will be puzzled with the simple question (and probably not the
> only one): Why are these in the series? Do they dependent or independent? What's
> the goal and how they should be routed? (You see, there are already 4).
> 
> > Is this a hard and fast rule that a cover letter MUST be there?
> 
> Cover letter SHOULD be there if there are more than one patch.
> Yes, there are exceptions, but this is the idea for the series.

FWIW, two more points:
1) yes, it's a MUST for some subsystems (BPF has this even documented);
2) there are tools (`b4`) that rely on the cover letter (shazam feature
or multiplying trailers if it/they was/were given against the cover letter).

> Use your common sense, if there is no documented thingy.

-- 
With Best Regards,
Andy Shevchenko