linux-kernel - RE: [EXTERNAL] [PATCH] RDMA/mana_ib: Ensure variable err is initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA6PR21MB4231810186481AF0A68AAC6ECEC72@SA6PR21MB4231.namprd21.prod.outlook.com>
Date: Fri, 21 Feb 2025 20:34:43 +0000
From: Long Li <longli@...rosoft.com>
To: Kees Bakker <kees@...erbout.nl>, Konstantin Taranov
	<kotaranov@...rosoft.com>, Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky
	<leon@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH] RDMA/mana_ib: Ensure variable err is
 initialized

> Subject: [EXTERNAL] [PATCH] RDMA/mana_ib: Ensure variable err is initialized
> 
> [Some people who received this message don't often get email from
> kees@...erbout.nl. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> In the function mana_ib_gd_create_dma_region if there are no dma blocks to
> process the variable `err` remains uninitialized.
> 
> Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure
> Network Adapter")
> Signed-off-by: Kees Bakker <kees@...erbout.nl>

I think it's an impossible condition, but the patch looks good to me.

Reviewed-by: Long Li <longli@...rosoft.com>

> ---
>  drivers/infiniband/hw/mana/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mana/main.c
> b/drivers/infiniband/hw/mana/main.c
> index 114ca8c509ce..eda9c5b971de 100644
> --- a/drivers/infiniband/hw/mana/main.c
> +++ b/drivers/infiniband/hw/mana/main.c
> @@ -384,7 +384,7 @@ static int mana_ib_gd_create_dma_region(struct
> mana_ib_dev *dev, struct ib_umem
>         unsigned int tail = 0;
>         u64 *page_addr_list;
>         void *request_buf;
> -       int err;
> +       int err = 0;
> 
>         gc = mdev_to_gc(dev);
>         hwc = gc->hwc.driver_data;
> --
> 2.48.1