linux-kernel - [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com>
Date: Fri, 21 Feb 2025 21:39:32 +0100
From: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: kernel@...labora.com, linux-sound@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
Subject: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes

Some tools like KGraphViewer interpret the "ON" nodes not having an
explicitly set fill colour as them being entirely black, which obscures
the text on them and looks funny. In fact, I thought they were off for
the longest time. Comparing to the output of the `dot` tool, I assume
they are supposed to be white.

Instead of speclawyering over who's in the wrong and must immediately
atone for their wickedness at the altar of RFC2119, just be explicit
about it, set the fillcolor to white, and nobody gets confused.

Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
---
This is somewhat "just thrown out there"; I noticed that not setting the
fill colour breaks KGraphViewer only *after* I thought this was just how
they were for several days. With this change, both dot and KGraphViewer
render it correctly, but I have no clue as to whether it's in the spirit
of the file format at all. I figure that if this saves some other poor
souls a bit of time and confusion, then it's worth it.
---
 tools/sound/dapm-graph | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/sound/dapm-graph b/tools/sound/dapm-graph
index f14bdfedee8f11507a6b7b04f6dd1847513e6da8..b6196ee5065a4e72069df663775518352d75d410 100755
--- a/tools/sound/dapm-graph
+++ b/tools/sound/dapm-graph
@@ -10,7 +10,7 @@ set -eu
 
 STYLE_COMPONENT_ON="color=dodgerblue;style=bold"
 STYLE_COMPONENT_OFF="color=gray40;style=filled;fillcolor=gray90"
-STYLE_NODE_ON="shape=box,style=bold,color=green4"
+STYLE_NODE_ON="shape=box,style=bold,color=green4,fillcolor=white"
 STYLE_NODE_OFF="shape=box,style=filled,color=gray30,fillcolor=gray95"
 
 # Print usage and exit

---
base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
change-id: 20250221-dapm-graph-node-colour-eb0011a45856

Best regards,
-- 
Nicolas Frattaroli <nicolas.frattaroli@...labora.com>