linux-kernel - Re: [PATCH v4 5/7] dmaengine: sh: rz-dmac: Allow for multiple DMACs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8tV1gw_m1_5PyQNzf=uRZmYr7N9RMiQxQF+PKxSOE6C4w@mail.gmail.com>
Date: Fri, 21 Feb 2025 21:25:57 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc: Vinod Koul <vkoul@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Biju Das <biju.das.jz@...renesas.com>, 
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v4 5/7] dmaengine: sh: rz-dmac: Allow for multiple DMACs

On Thu, Feb 20, 2025 at 3:02 PM Fabrizio Castro
<fabrizio.castro.jz@...esas.com> wrote:
>
> dma_request_channel() calls into __dma_request_channel() with
> NULL as value for np, which won't allow for the selection of the
> correct DMAC when multiple DMACs are available.
>
> Switch to using __dma_request_channel() directly so that we can
> choose the desired DMA for the channel. This is in preparation
> of adding DMAC support for the Renesas RZ/V2H(P) and similar SoCs.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> ---
> v3->v4:
> * No change.
> v2->v3:
> * Added () for calls in changelog.
> v1->v2:
> * No change.
> ---
>  drivers/dma/sh/rz-dmac.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
> index 9235db551026..d7a4ce28040b 100644
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -748,7 +748,8 @@ static struct dma_chan *rz_dmac_of_xlate(struct of_phandle_args *dma_spec,
>         dma_cap_zero(mask);
>         dma_cap_set(DMA_SLAVE, mask);
>
> -       return dma_request_channel(mask, rz_dmac_chan_filter, dma_spec);
> +       return __dma_request_channel(&mask, rz_dmac_chan_filter, dma_spec,
> +                                    ofdma->of_node);
>  }
>
>  /*
> --
> 2.34.1
>
>