linux-kernel - Re: [PATCH] kbuild: hdrcheck: fix cross build with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4045e93b-3352-428e-91c6-a86dc8f9c8bd@app.fastmail.com>
Date: Fri, 21 Feb 2025 22:39:59 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Nathan Chancellor" <nathan@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Masahiro Yamada" <masahiroy@...nel.org>,
 "Nicolas Schier" <nicolas@...sle.eu>,
 "Nick Desaulniers" <nick.desaulniers+lkml@...il.com>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt" <justinstitt@...gle.com>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] kbuild: hdrcheck: fix cross build with clang

On Fri, Feb 21, 2025, at 22:26, Nathan Chancellor wrote:
> On Fri, Feb 21, 2025 at 10:20:07PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The headercheck tries to call clang with a mix of compiler arguments
>> that don't include the target architecture. When building e.g. x86
>> headers on arm64, this produces a warning like
>> 
>>    clang: warning: unknown platform, assuming -mfloat-abi=soft
>> 
>> Add in the CLANG_FLAGS, which contain the target, in order to make it
>> build properly.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> This looks like a similar problem as the one fixed by
> commit 1b71c2fb04e7 ("kbuild: userprogs: fix bitsize and target
> detection on clang"), should it be addressed in the same manner
> (especially since I think the Fixes commit would be the same)? Given
> that the filter expression is the same, maybe it would be possible to
> unify them but that could happen as a follow up.

My bad, I actually had an old patch that addressed both issues
and then dropped it when the Thomas' patch made it into linux-next
but ended up picking my old change for usr/include/Makefile instead
of trying to understand the difference.

I'll send a v2 after some more build testing.

     Arnd