linux-kernel - Re: [PATCH] ASoC: codecs: wsa883x: Implement temperature reading and hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D7XPK4C7YYVN.2H85SNZIOOPAB@linaro.org>
Date: Fri, 21 Feb 2025 00:47:22 +0000
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Steev Klimaszewski" <steev@...i.org>
Cc: <srinivas.kandagatla@...aro.org>, <broonie@...nel.org>,
 <lgirdwood@...il.com>, <krzysztof.kozlowski@...aro.org>, <perex@...ex.cz>,
 <tiwai@...e.com>, <jdelvare@...e.com>, <linux@...ck-us.net>,
 <linux-sound@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: wsa883x: Implement temperature reading
 and hwmon

On Tue Jan 7, 2025 at 10:25 PM GMT, Steev Klimaszewski wrote:
> Hi Alexey,
> Thank you for this!

Hi Steev,

Thank you for testing. This really helps.
And sorry for slowly getting back to you.

> I've tested this on my Thinkpad X13s which has the wsa883x, and here,
> when idle, I see an entry, sdw:1:0:0217:0202:00:1 which shows ~26-28C
> when idle, as well as sdw:1:0:0217:0202:00:2 which has ~22-24C when
> idle, however if I play audio, both of them drop to 1C and do not move
> from that while audio is playing.  Is this expected behaviour
> currently?
>
> (out of laziness to repeat what I am doing here - I have bottom
> (https://github.com/clementtsang/bottom) running in 1 terminal, and
> then in a second terminal I either play an audio file with
> canbetrra-gtk-play or mpv a video with audio and for the entire time
> that there is audio playback, the temperature sits at 1C.

As far as I am aware there is some hw limitation resulting in that
temperature is not updating during playback/when amplifier is active or
that it is not allowed to read temp registers when the amplifier is active.

However, we should return the last good value here and not drop temp to 1C.
I think I found what the problem was and I will resend the new version soon.

Also, on sm8750 I see the 4-5 degree Celcius temperature diff between two
amplifiers (30C and 35C for instance).

Thanks,
Alexey