linux-kernel - Re: [PATCH] selftests/sysctl: fix wording of help messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <jwbsuecaakpeuekxy2p6i4ycklso7rbvh6opv6ezpjcm7sfald@3y7v3e6avw6g>
Date: Fri, 21 Feb 2025 09:48:08 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Bharadwaj Raju <bharadwaj.raju777@...il.com>
Cc: kees@...nel.org, shuah@...nel.org, skhan@...uxfoundation.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] selftests/sysctl: fix wording of help messages

On Sun, Feb 16, 2025 at 11:31:50AM +0530, Bharadwaj Raju wrote:
> Fix paramter -> parameter, and recomended ->
> recommended in sysctl.sh's help messages.
> 
> Also correct grammar: "number amount of times
> is recommended" etc -> "the recommended number of
> times".
> 
> Signed-off-by: Bharadwaj Raju <bharadwaj.raju777@...il.com>
> ---
>  tools/testing/selftests/sysctl/sysctl.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
> index 84472b436c07..a8e5736e89a8 100755
> --- a/tools/testing/selftests/sysctl/sysctl.sh
> +++ b/tools/testing/selftests/sysctl/sysctl.sh
> @@ -764,7 +764,7 @@ sysctl_test_0007()
>  	fi
>  
>  	if [ ! -f /proc/cmdline ]; then
> -		echo -e "SKIPPING\nThere is no /proc/cmdline to check for paramter"
> +		echo -e "SKIPPING\nThere is no /proc/cmdline to check for parameter"
>  		return $ksft_skip
>  	fi
I have already taken this

>  
> @@ -884,7 +884,7 @@ usage()
>  	echo "Valid tests: 0001-$MAX_TEST"
>  	echo ""
>  	echo "    all     Runs all tests (default)"
> -	echo "    -t      Run test ID the number amount of times is recommended"
> +	echo "    -t      Run test ID the recommended number of times"
>  	echo "    -w      Watch test ID run until it runs into an error"
>  	echo "    -c      Run test ID once"
>  	echo "    -s      Run test ID x test-count number of times"
> @@ -898,7 +898,7 @@ usage()
>  	echo Example uses:
>  	echo
>  	echo "$TEST_NAME.sh            -- executes all tests"
> -	echo "$TEST_NAME.sh -t 0002    -- Executes test ID 0002 number of times is recomended"
> +	echo "$TEST_NAME.sh -t 0002    -- Executes test ID 0002 the recommended number of times"
>  	echo "$TEST_NAME.sh -w 0002    -- Watch test ID 0002 run until an error occurs"
>  	echo "$TEST_NAME.sh -s 0002    -- Run test ID 0002 once"
>  	echo "$TEST_NAME.sh -c 0002 3  -- Run test ID 0002 three times"
> -- 
> 2.48.1
> 

Can you please resend based on sysclt-next

https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next

Best

-- 

Joel Granados