linux-kernel - Re: [PATCH] drivers/firmware/efi: Fix cper_ia_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXEcd33qWJHDxwOun=EF4mDLHRw9YtiPKUaeMAmsbpfLYQ@mail.gmail.com>
Date: Fri, 21 Feb 2025 10:05:15 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Patrick Rudolph <patrick.rudolph@...ements.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/firmware/efi: Fix cper_ia_proc_ctx alignment

On Fri, 21 Feb 2025 at 09:13, Patrick Rudolph
<patrick.rudolph@...ements.com> wrote:
>
> According to the UEFI Common Platform Error Record appendix, the
> IA32/X64 Processor Context Information Structure is a variable length
> structure, but "is padded with zeros if the size is not a multiple
> of 16 bytes".
>
> Currently this isn't honoured, causing all but the first structure to
> be garbage when printed. Thus align the size to be a multiple of 16.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> ---
>  drivers/firmware/efi/cper-x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
> index 438ed9eff6d0..3949d7b5e808 100644
> --- a/drivers/firmware/efi/cper-x86.c
> +++ b/drivers/firmware/efi/cper-x86.c
> @@ -325,7 +325,7 @@ void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
>
>         ctx_info = (struct cper_ia_proc_ctx *)err_info;
>         for (i = 0; i < VALID_PROC_CXT_INFO_NUM(proc->validation_bits); i++) {
> -               int size = sizeof(*ctx_info) + ctx_info->reg_arr_size;
> +               int size = ALIGN(sizeof(*ctx_info) + ctx_info->reg_arr_size, 16);
>                 int groupsize = 4;
>
>                 printk("%sContext Information Structure %d:\n", pfx, i);

Thanks for the patch. It seems ARM suffers from the same issue, mind
fixing that too?