linux-kernel - Re: [PATCH] LoongArch: vDSO: Remove --hash-style=sysv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H5_bKtO2mAFmfcZvD0pn9RhTA+UPjv7K574uPKxZbxX=g@mail.gmail.com>
Date: Fri, 21 Feb 2025 17:47:16 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Xi Ruoyao <xry111@...111.site>
Cc: WANG Xuerui <kernel@...0n.name>, Masahiro Yamada <masahiroy@...nel.org>, 
	Tiezhu Yang <yangtiezhu@...ngson.cn>, "Jason A. Donenfeld" <Jason@...c4.com>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: vDSO: Remove --hash-style=sysv

Hi, Ruoyao,

On Fri, Feb 21, 2025 at 5:25 PM Xi Ruoyao <xry111@...111.site> wrote:
>
> glibc added support for .gnu.hash in 2006 and .hash has been obsoleted
> far before the first LoongArch CPU was taped.  Using
> --hash-style=sysv might imply unaddressed issues and confuse readers.
>
> In the past we really had an unaddressed issue: the vdso selftests did
> not know how to process .gnu.hash.  But it has been addressed by commit
> e0746bde6f82 ("selftests/vDSO: support DT_GNU_HASH") now.
>
> Just drop the option and rely on the linker default, which is likely
> "both" (AOSC) or "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch
> distros.
What about changing to "--hash-style=both" as most architectures do?

Huacai

>
> Similar to commit 6b7e26547fad ("x86/vdso: Emit a GNU hash") and commit
> 48f6430505c0 ("arm64/vdso: Remove --hash-style=sysv").
>
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  arch/loongarch/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index fdde1bcd4e26..abaf87c58f9d 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -37,7 +37,7 @@ endif
>  # VDSO linker flags.
>  ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
>         $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
> -       --hash-style=sysv --build-id -T
> +       --build-id -T
>
>  #
>  # Shared build commands.
> --
> 2.48.1
>