linux-kernel - Re: [PATCH] drm/atomic-helper: Add a note in drm_atomic_helper_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7hMhEz_hTymarO1@phenom.ffwll.local>
Date: Fri, 21 Feb 2025 10:51:00 +0100
From: Simona Vetter <simona.vetter@...ll.ch>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH] drm/atomic-helper: Add a note in
 drm_atomic_helper_reset_crtc() kernel-doc

On Thu, Feb 20, 2025 at 03:04:06PM +0100, Herve Codina wrote:
> As suggested in [0], add a note indicating that
> drm_atomic_helper_reset_crtc() can be a no-op in some cases.
> 
> [0]:https://lore.kernel.org/all/Z7XfnPGDYspwG42y@phenom.ffwll.local/
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Simona Vetter <simona.vetter@...ll.ch>

I'm assuming you or someone else at bootling has commit rights? Otherwise
I guess on Maxime to get that sorted.
-Sima

> ---
>  This patch applies on top of the following commit available in drm-misc
>    ab83b7f6a0c1 ("drm/atomic-helper: Introduce drm_atomic_helper_reset_crtc()")
> 
>  drivers/gpu/drm/drm_atomic_helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 0a636c398578..1f93b0a855de 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -3371,6 +3371,10 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all);
>   * This implies a reset of all active components available between the CRTC and
>   * connectors.
>   *
> + * NOTE: This relies on resetting &drm_crtc_state.connectors_changed.
> + * For drivers which optimize out unnecessary modesets this will result in
> + * a no-op commit, achieving nothing.
> + *
>   * Returns:
>   * 0 on success or a negative error code on failure.
>   */
> -- 
> 2.48.1
> 

-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch