linux-kernel - Re: [PATCH v2 2/2] drm/draw: include bug.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7hMPIxFyd6cqbC0@phenom.ffwll.local>
Date: Fri, 21 Feb 2025 10:49:48 +0100
From: Simona Vetter <simona.vetter@...ll.ch>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Raag Jadav <raag.jadav@...el.com>, arnd@...db.de,
	andriy.shevchenko@...ux.intel.com, airlied@...il.com,
	simona@...ll.ch, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm/draw: include bug.h

On Fri, Feb 21, 2025 at 07:05:12AM +0100, Greg KH wrote:
> On Fri, Feb 21, 2025 at 10:38:04AM +0530, Raag Jadav wrote:
> > Directly include bug.h for WARN() helpers instead of relying on
> > intermediate headers.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> > ---
> >  drivers/gpu/drm/drm_draw.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c
> > index cb2ad12bce57..0a0e1eebf481 100644
> > --- a/drivers/gpu/drm/drm_draw.c
> > +++ b/drivers/gpu/drm/drm_draw.c
> > @@ -5,6 +5,7 @@
> >   */
> >  
> >  #include <linux/bits.h>
> > +#include <linux/bug.h>
> >  #include <linux/iosys-map.h>
> >  #include <linux/types.h>
> >  
> > -- 
> > 2.34.1
> > 
> 
> Does patch 1 break this file without this patch so this series is not in
> order?
> 
> I'll be glad to take patch 1 in my tree, but I don't want to break
> anything else.

Yeah looks inverted. In case this is all there is I'm happy to land this
patch through your tree, that seems like the simplest approach.

Acked-by: Simona Vetter <simona.vetter@...ll.ch>

Cheers, Sima
-- 
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch