linux-kernel - Re: [PATCH] LoongArch: vDSO: Remove --hash-style=sysv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4rDXDnzJwUE6PXMyuNGTs1NwUzQDP5eAPMmaHpqftP-Q@mail.gmail.com>
Date: Fri, 21 Feb 2025 18:26:11 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Xi Ruoyao <xry111@...111.site>
Cc: Guo Ren <guoren@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Fangrui Song <i@...kray.me>, 
	WANG Xuerui <kernel@...0n.name>, Masahiro Yamada <masahiroy@...nel.org>, 
	Tiezhu Yang <yangtiezhu@...ngson.cn>, "Jason A. Donenfeld" <Jason@...c4.com>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	linux-csky@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] LoongArch: vDSO: Remove --hash-style=sysv

On Fri, Feb 21, 2025 at 6:23 PM Xi Ruoyao <xry111@...111.site> wrote:
>
> On Fri, 2025-02-21 at 17:47 +0800, Huacai Chen wrote:
> > Hi, Ruoyao,
> >
> > On Fri, Feb 21, 2025 at 5:25 PM Xi Ruoyao <xry111@...111.site> wrote:
> > >
> > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted
> > > far before the first LoongArch CPU was taped.  Using
> > > --hash-style=sysv might imply unaddressed issues and confuse readers.
> > >
> > > In the past we really had an unaddressed issue: the vdso selftests did
> > > not know how to process .gnu.hash.  But it has been addressed by commit
> > > e0746bde6f82 ("selftests/vDSO: support DT_GNU_HASH") now.
> > >
> > > Just drop the option and rely on the linker default, which is likely
> > > "both" (AOSC) or "gnu" (Arch, Debian, Gentoo, LFS) on all LoongArch
> > > distros.
> > What about changing to "--hash-style=both" as most architectures do?
>
> IMO we are more close to ARM64 for the aspect that there are no libc
> (glibc or musl) releases lacking GNU hash support, so I prefer the ARM64
> way.
>
> Maybe this should be changed for some of other architectures (RISC-V and
> C-SKY?) as well because I guess the only reason they used "both" was
> "hey, without this the self tests don't work on Debian" but this is
> resolved now.  Adding a few recipients and Cc for discussion.
OK, maybe we can change it for RISC-V/C-SKY and see what they will.

Huacai

>
> --
> Xi Ruoyao <xry111@...111.site>
> School of Aerospace Science and Technology, Xidian University