linux-kernel - [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250221104357.1514128-1-kever.yang@rock-chips.com>
Date: Fri, 21 Feb 2025 18:43:55 +0800
From: Kever Yang <kever.yang@...k-chips.com>
To: heiko@...ech.de
Cc: linux-rockchip@...ts.infradead.org,
	Kever Yang <kever.yang@...k-chips.com>,
	Simon Xue <xxm@...k-chips.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Detlev Casanova <detlev.casanova@...labora.com>,
	Finley Xiao <finley.xiao@...k-chips.com>,
	Frank Wang <frank.wang@...k-chips.com>,
	Rob Herring <robh@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org,
	Liang Chen <cl@...k-chips.com>,
	Krzysztof Wilczyński <kw@...ux.com>,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	devicetree@...r.kernel.org,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Elaine Zhang <zhangqing@...k-chips.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes


The make dt_binding_check test has pass.
But I got error for make CHECK_DTBS=y as below
  DTC [C] arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dtb
  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb
/home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pcie@...00000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long
	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
/home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pcie@...10000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long
	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb
/home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: pcie@...00000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long
	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
/home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: pcie@...10000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long
	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml#
  DTC [C] arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb
/home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: pcie-ep@...50000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'dma0', 'dma1', 'dma2', 'dma3'] is too long
	from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml#

Could anyone told me why, the rk3568 has pass the test, but the rk3572
and rk3588 failed.
How can I debug the yaml check failure? Why the check rule does not go to
the if branch I defined for rk3572 and rk3588?


Changes in v6:
- Fix make dt_binding_check and make CHECK_DTBS=y

Changes in v5:
- Add constraints per device for interrupt-names due to the interrupt is
different from rk3588.

Changes in v4:
- Fix wrong indentation in dt_binding_check report by Rob

Changes in v3:
- Fix dtb check broken on rk3588
- Update commit message
- Update the subject

Changes in v2:
- remove required 'msi-map'
- add interrupt name 'msi'
- Update clock and reset names and sequence to pass DTB check

Kever Yang (2):
  dt-bindings: PCI: dw: rockchip: Add rk3576 support
  arm64: dts: rockchip: Add rk3576 pcie nodes

 .../bindings/pci/rockchip-dw-pcie-common.yaml |  59 ++++++++--
 .../bindings/pci/rockchip-dw-pcie.yaml        |   4 +-
 arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 109 ++++++++++++++++++
 3 files changed, 159 insertions(+), 13 deletions(-)

-- 
2.25.1