linux-kernel - Re: [PATCH v2] riscv: KVM: Remove unnecessary vcpu kick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7Y30THD6TSI.113LHMD3DBBCP@ventanamicro.com>
Date: Fri, 21 Feb 2025 12:20:25 +0100
From: Radim Krčmář <rkrcmar@...tanamicro.com>
To: "BillXiang" <xiangwencheng@...xincomputing.com>, <anup@...infault.org>
Cc: <ajones@...tanamicro.com>, <kvm-riscv@...ts.infradead.org>,
 <kvm@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>, <atishp@...shpatra.org>,
 <paul.walmsley@...ive.com>, <palmer@...belt.com>, <aou@...s.berkeley.edu>
Subject: Re: [PATCH v2] riscv: KVM: Remove unnecessary vcpu kick

2025-02-21T18:45:38+08:00, BillXiang <xiangwencheng@...xincomputing.com>:
> Remove the unnecessary kick to the vCPU after writing to the vs_file
> of IMSIC in kvm_riscv_vcpu_aia_imsic_inject.
>
> For vCPUs that are running, writing to the vs_file directly forwards
> the interrupt as an MSI to them and does not need an extra kick.
>
> For vCPUs that are descheduled after emulating WFI, KVM will enable
> the guest external interrupt for that vCPU in
> kvm_riscv_aia_wakeon_hgei. This means that writing to the vs_file
> will cause a guest external interrupt, which will cause KVM to wake
> up the vCPU in hgei_interrupt to handle the interrupt properly.
>
> Signed-off-by: BillXiang <xiangwencheng@...xincomputing.com>
> ---
> v2: Revise the commit message to ensure it meets the required 
>     standards for acceptance

Nice, thanks.

Reviewed-by: Radim Krčmář <rkrcmar@...tanamicro.com>