linux-kernel - Re: [PATCH] soc: mediatek: mtk-socinfo: Avoid using machine attribute in SoC detection log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC=S1njHBs27TtTZXgED4wdLw=FrSDCazbb6ZssZywvSWV2h3A@mail.gmail.com>
Date: Fri, 21 Feb 2025 19:34:51 +0800
From: Fei Shao <fshao@...omium.org>
To: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
Cc: Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, kernel@...labora.com, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mediatek: mtk-socinfo: Avoid using machine attribute
 in SoC detection log

On Fri, Feb 21, 2025 at 7:04 PM Louis-Alexis Eyraud
<louisalexis.eyraud@...labora.com> wrote:
>
> The recently introduced SoC attribute info rework avoided modifying the
> machine attribut but still used it in the log message on successful SoC
> matching. It leads to print a confusing log about a board-related info
> (read from devicetree) and not about the matched SoC:
> ```
> mtk-socinfo mtk-socinfo.0.auto: MediaTek MediaTek Genio-510 EVK SoC
>   detected
> ```
>
> So, fix the dev_info format to display SoC family and name attribute
> instead.
> ```
> mtk-socinfo mtk-socinfo.0.auto: MediaTek Genio 510 (MT8370) SoC detected.
> ```
>
> Fixes: da77c2d3d06c ("soc: mediatek: mtk-socinfo: Restructure SoC attribute information")
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>

Ah... my bad, I forgot to update the log. Thanks for the follow-up fix.

Reviewed-by: Fei Shao <fshao@...omium.org>
Tested-by: Fei Shao <fshao@...omium.org>

> ---
>  drivers/soc/mediatek/mtk-socinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c
> index a15d8f854cefa90883377b47bbc16a7072ee21cd..ac7bb0cbff2df5e1c4033646cd3b644e67ee7f69 100644
> --- a/drivers/soc/mediatek/mtk-socinfo.c
> +++ b/drivers/soc/mediatek/mtk-socinfo.c
> @@ -87,7 +87,7 @@ static int mtk_socinfo_create_socinfo_node(struct mtk_socinfo *mtk_socinfop)
>         if (IS_ERR(mtk_socinfop->soc_dev))
>                 return PTR_ERR(mtk_socinfop->soc_dev);
>
> -       dev_info(mtk_socinfop->dev, "%s %s SoC detected.\n", soc_manufacturer, attrs->machine);
> +       dev_info(mtk_socinfop->dev, "%s (%s) SoC detected.\n", attrs->family, attrs->soc_id);
>         return 0;
>  }
>
>
> ---
> base-commit: 964b0ceed00032fa0fa841fd61e5f315880a2d36
> change-id: 20250220-mtk-socinfo-fix-print-e83f3b3e50bb
>
> Best regards,
> --
> Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
>