linux-kernel - Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F0268324-2013-41B0-8827-4B3E24374CFE@live.com>
Date: Fri, 21 Feb 2025 11:40:22 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Rasmus Villemoes <linux@...musvillemoes.dk>
CC: "pmladek@...e.com" <pmladek@...e.com>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "senozhatsky@...omium.org"
	<senozhatsky@...omium.org>, "corbet@....net" <corbet@....net>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "apw@...onical.com" <apw@...onical.com>,
	"joe@...ches.com" <joe@...ches.com>, "dwaipayanray1@...il.com"
	<dwaipayanray1@...il.com>, "lukas.bulwahn@...il.com"
	<lukas.bulwahn@...il.com>, "sumit.semwal@...aro.org"
	<sumit.semwal@...aro.org>, "christian.koenig@....com"
	<christian.koenig@....com>, "kekrby@...il.com" <kekrby@...il.com>,
	"admin@...eit.net" <admin@...eit.net>, Orlando Chamberlain
	<orlandoch.dev@...il.com>, "evepolonium@...il.com" <evepolonium@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>, Hector
 Martin <marcan@...can.st>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"asahi@...ts.linux.dev" <asahi@...ts.linux.dev>, Sven Peter
	<sven@...npeter.dev>, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v2 2/3] lib/vsprintf: Add support for generic FOURCCs by
 extending %p4cc

Hi

> 
>> 
>> diff --git a/lib/test_printf.c b/lib/test_printf.c
>> index 59dbe4f9a..ee860327e 100644
>> --- a/lib/test_printf.c
>> +++ b/lib/test_printf.c
>> @@ -776,21 +776,46 @@ static void __init fwnode_pointer(void)
>> software_node_unregister_node_group(group);
>> }
>> 
>> +struct fourcc_struct {
>> + u32 code;
>> + const char *str;
>> +};
>> +
>> +static void __init fourcc_pointer_test(const struct fourcc_struct *fc, size_t n,
>> +       const char *fmt)
>> +{
>> + size_t i;
>> +
>> + for (i = 0; i < n; i++)
>> + test(fc[i].str, fmt, &fc[i].code);
>> +}
>> +
>> static void __init fourcc_pointer(void)
>> {
>> - struct {
>> - u32 code;
>> - char *str;
>> - } const try[] = {
>> + struct fourcc_struct const try_cc[] = {
> 
> I know it matches the code it replaces, but kernel style seems to be
> "const struct foo" rather than "struct foo const" (at around 130:1) -
> just as you use in the new helper function.
> 
> Also, please consider changing the array, and the newly added instances,
> to be static instead of automatic (our le32_to_cpu should be usable also
> for static initializers).
> 

V3 sent here:
https://lore.kernel.org/dri-devel/98289BC4-D5E1-41B8-AC89-632DBD2C2789@live.com/T/#mfa1dac647c9517674649a50301b122a524cc364c