linux-kernel - Re: [PATCH v5 3/5] gpio: spacemit: add support for K1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250221122125-GYA35549@gentoo>
Date: Fri, 21 Feb 2025 12:21:25 +0000
From: Yixun Lan <dlan@...too.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Chen Wang <unicorn_wang@...look.com>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Meng Zhang <zhangmeng.kevin@...ux.spacemit.com>,
	linux-gpio@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, Conor Dooley <conor@...nel.org>,
	Yangyu Chen <cyy@...self.name>, devicetree@...r.kernel.org,
	Palmer Dabbelt <palmer@...belt.com>,
	Jesse Taube <mr.bossman075@...il.com>,
	Jisheng Zhang <jszhang@...nel.org>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Inochi Amaoto <inochiama@...look.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, spacemit@...ts.linux.dev,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 3/5] gpio: spacemit: add support for K1 SoC

Hi Bartosz Golaszewski:

On 09:37 Fri 21 Feb     , Bartosz Golaszewski wrote:
> On Fri, Feb 21, 2025 at 12:36 AM Chen Wang <unicorn_wang@...look.com> wrote:
> >
> >
> > On 2025/2/20 21:34, Bartosz Golaszewski wrote:
> > > On Mon, Feb 17, 2025 at 1:58 PM Yixun Lan <dlan@...too.org> wrote:
> > [......]
> > >> +#define to_spacemit_gpio_bank(x) container_of((x), struct spacemit_gpio_bank, gc)
> > >> +
> > >> +struct spacemit_gpio;
> > >> +
> > >> +struct spacemit_gpio_bank {
> > >> +       struct gpio_chip                gc;
> > >> +       struct spacemit_gpio            *sg;
> > >> +       void __iomem                    *base;
> > >> +       u32                             index;
> > >> +       u32                             irq_mask;
> > >> +       u32                             irq_rising_edge;
> > >> +       u32                             irq_falling_edge;
> > >> +};
> > >> +
> > >> +struct spacemit_gpio {
> > >> +       struct  device                  *dev;
> > >> +       struct  spacemit_gpio_bank      sgb[NR_BANKS];
> > >> +};
> > > Please don't use tabs in struct definitions.
> >
> > Why not？I see
> > https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#struct-declarations-and-initializers
> >
> 
> This is for the tip tree, not treewide.
> 
> It's my personal maintainer preference. We do use both under
> drivers/gpio/ but I prefer no-tabs in new code.
> 

thanks for this explanation..

my intention was trying to keep struct members aligned
if tabs is a no-go, would using multi blank spaces to align be acceptable?

something like:

struct spacemit_gpio_bank {
	struct gpio_chip       gc;
	struct spacemit_gpio   *sg;
	void   __iomem         *base;
       ...
}

> Bart

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55