| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1240320242.634119.1740141152414.JavaMail.zimbra@couthit.local>
Date: Fri, 21 Feb 2025 18:02:32 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: robh <robh@...nel.org>
Cc: parvathi <parvathi@...thit.com>, danishanwar <danishanwar@...com>,
rogerq <rogerq@...nel.org>, andrew+netdev <andrew+netdev@...n.ch>,
davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>,
kuba <kuba@...nel.org>, pabeni <pabeni@...hat.com>,
krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>,
nm <nm@...com>, ssantosh <ssantosh@...nel.org>,
richardcochran <richardcochran@...il.com>,
basharath <basharath@...thit.com>, schnelle <schnelle@...ux.ibm.com>,
diogo ivo <diogo.ivo@...mens.com>,
m-karicheri2 <m-karicheri2@...com>, horms <horms@...nel.org>,
jacob e keller <jacob.e.keller@...el.com>,
m-malladi <m-malladi@...com>,
javier carrasco cruz <javier.carrasco.cruz@...il.com>,
afd <afd@...com>, s-anna <s-anna@...com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
netdev <netdev@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>,
Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>,
srk <srk@...com>, rogerq <rogerq@...com>,
krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>,
mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v3 01/10] dt-bindings: net: ti: Adds DUAL-EMAC
mode support on PRU-ICSS2 for AM57xx SOCs
Hi,
> On Fri, Feb 14, 2025 at 11:16:53AM +0530, parvathi wrote:
>> From: Parvathi Pudi <parvathi@...thit.com>
>>
>> Documentation update for the newly added "pruss2_eth" device tree
>> node and its dependencies along with compatibility for PRU-ICSS
>> Industrial Ethernet Peripheral (IEP), PRU-ICSS Enhanced Capture
>> (eCAP) peripheral and using YAML binding document for AM57xx SoCs.
>>
>> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
>> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
>
> The sender of the patch S-o-b goes last. And maybe you want a
> Co-developed-by tag here too?
>
Yes, you are correct. We will address this in the next version.
>> ---
>> .../devicetree/bindings/net/ti,icss-iep.yaml | 4 +-
>> .../bindings/net/ti,icssm-prueth.yaml | 147 ++++++++++++++++++
>> .../bindings/net/ti,pruss-ecap.yaml | 32 ++++
>> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 9 ++
>> 4 files changed, 191 insertions(+), 1 deletion(-)
>> create mode 100644 Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
>> create mode 100644 Documentation/devicetree/bindings/net/ti,pruss-ecap.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
>> b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
>> index e36e3a622904..858d74638167 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml
>> @@ -8,6 +8,8 @@ title: Texas Instruments ICSS Industrial Ethernet Peripheral
>> (IEP) module
>>
>> maintainers:
>> - Md Danish Anwar <danishanwar@...com>
>> + - Parvathi Pudi <parvathi@...thit.com>
>> + - Basharath Hussain Khaja <basharath@...thit.com>
>>
>> properties:
>> compatible:
>> @@ -19,7 +21,7 @@ properties:
>> - const: ti,am654-icss-iep
>>
>> - const: ti,am654-icss-iep
>> -
>> + - const: ti,am5728-icss-iep
>
> Use enum adding to the prior entry.
>
We will check whether we can use "enum" for 2 consts and address
this in the next version.
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
>> b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
>> new file mode 100644
>> index 000000000000..1dffa6bd7a88
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
>> @@ -0,0 +1,147 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/ti,icssm-prueth.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments ICSSM PRUSS Ethernet
>> +
>> +maintainers:
>> + - Roger Quadros <rogerq@...com>
>> + - Andrew F. Davis <afd@...com>
>> + - Parvathi Pudi <parvathi@...thit.com>
>> + - Basharath Hussain Khaja <basharath@...thit.com>
>> +
>> +description:
>> + Ethernet based on the Programmable Real-Time Unit and Industrial
>> + Communication Subsystem.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ti,am57-prueth # for AM57x SoC family
>> +
>> + sram:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to OCMC SRAM node
>> +
>> + ti,mii-rt:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to MII_RT module's syscon regmap
>> +
>> + ti,iep:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to IEP (Industrial Ethernet Peripheral) for ICSS
>> +
>> + ti,ecap:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description:
>> + phandle to Enhanced Capture (eCAP) event for ICSS
>> +
>> + interrupts:
>> + items:
>> + - description: High priority Rx Interrupt specifier.
>> + - description: Low priority Rx Interrupt specifier.
>> +
>> + interrupt-names:
>> + items:
>> + - const: rx_hp
>> + - const: rx_lp
>> +
>> + ethernet-ports:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + '#address-cells':
>> + const: 1
>> + '#size-cells':
>> + const: 0
>> +
>> + patternProperties:
>> + ^ethernet-port@[0-1]$:
>> + type: object
>> + description: ICSSM PRUETH external ports
>> + $ref: ethernet-controller.yaml#
>> + unevaluatedProperties: false
>> +
>> + properties:
>> + reg:
>> + items:
>> + - enum: [0, 1]
>> + description: ICSSM PRUETH port number
>> +
>> + interrupts:
>> + maxItems: 3
>> +
>> + interrupt-names:
>> + items:
>> + - const: rx
>> + - const: emac_ptp_tx
>> + - const: hsr_ptp_tx
>> +
>> + required:
>> + - reg
>> +
>> + anyOf:
>> + - required:
>> + - ethernet-port@0
>> + - required:
>> + - ethernet-port@1
>> +
>> +required:
>> + - compatible
>> + - sram
>> + - ti,mii-rt
>> + - ti,iep
>> + - ti,ecap
>> + - ethernet-ports
>> + - interrupts
>> + - interrupt-names
>> +
>> +allOf:
>> + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + /* Dual-MAC Ethernet application node on PRU-ICSS2 */
>> + pruss2_eth: pruss2-eth {
>
> Drop unused labels.
>
We did verified and all the labels were appropriately used,
could you point us to the exact label you are referring to.
Thanks and Regards,
Parvathi.
Powered by blists - more mailing lists