linux-kernel - Re: [PATCH] ACPI: NUMA: Move get_numa_distances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7h1XWyjKIkyR2zJ@kernel.org>
Date: Fri, 21 Feb 2025 14:45:17 +0200
From: Mike Rapoport <rppt@...nel.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: chenhuacai@...nel.org, kernel@...0n.name, rafael@...nel.org,
	lenb@...nel.org, maobibo@...ngson.cn, guanwentao@...ontech.com,
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jonathan.Cameron@...wei.com, dan.j.williams@...el.com,
	alison.schofield@...el.com, rrichter@....com, bfaccini@...dia.com,
	dave.jiang@...el.com, haibo1.xu@...el.com,
	linux-acpi@...r.kernel.org, zhanjun@...ontech.com,
	niecheng1@...ontech.com, chenlinxuan@...ontech.com
Subject: Re: [PATCH] ACPI: NUMA: Move get_numa_distances_cnt() helper to
 needed location

Hi,

On Thu, Feb 20, 2025 at 02:25:33PM +0800, WangYuli wrote:
> Hi Mike,
> 
> On 2025/2/20 14:10, Mike Rapoport wrote:
> > There's no need for relocation, just drop the unused function.
> 
> Okay.
> 
> But  please take a look at line 295 of the original srat.c. Should the type
> of variable 'd' there be changed to u64, as mentioned in the commit message?

int is enough for more than 2 million nodes, I don't see a problem with it
 
> If yes, I can quickly put up another commit just to tweak this one place.
> 
> Thanks,
> 
> -- 
> WangYuli






-- 
Sincerely yours,
Mike.