linux-kernel - Re: [PATCH *-next 13/18] gpiolib: Remove needless return in two void APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McG2xLUcE_yHq4MiFnm665riHHuHjk0GJE4cFV_gGU90Q@mail.gmail.com>
Date: Fri, 21 Feb 2025 14:06:23 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Zijun Hu <quic_zijuhu@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Will Deacon <will@...nel.org>, 
	"Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Nick Piggin <npiggin@...il.com>, Peter Zijlstra <peterz@...radead.org>, Arnd Bergmann <arnd@...db.de>, 
	Thomas Gleixner <tglx@...utronix.de>, Herbert Xu <herbert@...dor.apana.org.au>, 
	"David S. Miller" <davem@...emloft.net>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Danilo Krummrich <dakr@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Johannes Berg <johannes@...solutions.net>, Jamal Hadi Salim <jhs@...atatu.com>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, 
	Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Lee Jones <lee@...nel.org>, Thomas Graf <tgraf@...g.ch>, Christoph Hellwig <hch@....de>, 
	Marek Szyprowski <m.szyprowski@...sung.com>, Robin Murphy <robin.murphy@....com>, 
	Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, 
	Vignesh Raghavendra <vigneshr@...com>, Zijun Hu <zijun_hu@...oud.com>, linux-arch@...r.kernel.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-crypto@...r.kernel.org, netdev@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org, iommu@...ts.linux.dev, 
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH *-next 13/18] gpiolib: Remove needless return in two void APIs

On Fri, Feb 21, 2025 at 2:02 PM Zijun Hu <quic_zijuhu@...cinc.com> wrote:
>
> Remove needless 'return' in the following void APIs:
>
> gpio_set_value_cansleep()
> gpio_set_value()
>
> Since both the API and callee involved are void functions.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---

That would normally make sense but we're getting that reworked[1] in
this very cycle so please drop this patch from your series.

Bart

[1] https://lore.kernel.org/linux-gpio/20250220-gpio-set-retval-v2-0-bc4cfd38dae3@linaro.org/