linux-kernel - Re: [PATCH] LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H6-cH1a-ghgGAp2aOp8MF09YMwj3bCXESLts==d8_4m3Q@mail.gmail.com>
Date: Fri, 21 Feb 2025 21:42:12 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: WANG Xuerui <kernel@...0n.name>, loongarch@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Remove unused option with HAVE_VIRT_CPU_ACCOUNTING_GEN

Hi, Bibo,

On Fri, Feb 21, 2025 at 3:32 PM Bibo Mao <maobibo@...ngson.cn> wrote:
>
> Option HAVE_VIRT_CPU_ACCOUNTING_GEN is selected by default in kconfig file
> arch/Kconfig. It is meaningless in file arch/loongarch/Kconfig, and on the
> contrast it may bring out misunderstanding. Here remove it on arch
> specified kconfig file.
>
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>  arch/loongarch/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 2b8bd27a852f..7fd5708fe14a 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -175,7 +175,6 @@ config LOONGARCH
>         select HAVE_STACKPROTECTOR
>         select HAVE_SYSCALL_TRACEPOINTS
>         select HAVE_TIF_NOHZ
> -       select HAVE_VIRT_CPU_ACCOUNTING_GEN if !SMP
Please see 01f135506e2ed0403512 ("powerpc/32: select
HAVE_VIRT_CPU_ACCOUNTING_GEN"). Now HAVE_VIRT_CPU_ACCOUNTING_GEN is
available on both 32BIT and 64BIT, so I think a better solution is
unconditionally select HAVE_VIRT_CPU_ACCOUNTING_GEN which is
convenient for the upcoming LoongArch32.





Huacai

>         select IRQ_FORCED_THREADING
>         select IRQ_LOONGARCH_CPU
>         select LOCK_MM_AND_FIND_VMA
> --
> 2.39.3
>
>