linux-kernel - Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4988041.31r3eYUQgx@trenzalore>
Date: Fri, 21 Feb 2025 09:43:31 -0500
From: Detlev Casanova <detlev.casanova@...labora.com>
To: Piotr Oniszczuk <piotr.oniszczuk@...il.com>,
 Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: linux-kernel@...r.kernel.org, Algea Cao <algea.cao@...k-chips.com>,
 Heiko Stuebner <heiko@...ech.de>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 dri-devel@...ts.freedesktop.org, Niklas Cassel <cassel@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, kernel@...labora.com,
 David Airlie <airlied@...il.com>, Dragan Simic <dsimic@...jaro.org>,
 Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>,
 Robert Foss <rfoss@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Sugar Zhang <sugar.zhang@...k-chips.com>, linux-rockchip@...ts.infradead.org,
 Chen-Yu Tsai <wens@...e.org>, FUKAUMI Naoki <naoki@...xa.com>,
 devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 Jonas Karlman <jonas@...boo.se>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Johan Jonker <jbx6244@...il.com>, linux-arm-kernel@...ts.infradead.org,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Alexey Charkov <alchark@...il.com>, Thomas Zimmermann <tzimmermann@...e.de>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v7 0/3] Add HDMI audio on the rk3588 SoC

On Friday, 21 February 2025 06:42:31 EST Piotr Oniszczuk wrote:
> Small data point: on rock5b switching in dts analog audio: from
> audio-graph-card to simple-audio-card (so dts is:
> https://gist.github.com/warpme/349b27e49bc6f617ef1041047e75adab ) makes
> kernel oops go away with analog audio still working…
> 
> so maybe issue is in audio-graph-card code (or its dts fragments)?

I can reproduce with your config (I guess that removing the driver for analog 
audio hides the issue)

I'm really feel like simple_util_clean_reference(card) in simple_probe() 
errors path should not be called anymore, since
https://lore.kernel.org/all/87zfk4o5l2.wl-kuninori.morimoto.gx@renesas.com/

I'm adding Kuninori Morimoto in the to list of this thread for extra input 
(See thread at https://lore.kernel.org/all/B8EF5196-55FB-44EC-B93C-E327C791225B@gmail.com/) as they made that change.
Especially those commits:
      ASoC: audio-graph-card2: use __free(device_node) for device node
      ASoC: audio-graph-card: use __free(device_node) for device node
      ASoC: simple-card: use __free(device_node) for device node

Detlev.