linux-kernel - Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier for hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5162d16-e9fd-408f-9bc5-68748e4b1f87@arm.com>
Date: Fri, 21 Feb 2025 15:45:03 +0100
From: Dietmar Eggemann <dietmar.eggemann@....com>
To: Jon Hunter <jonathanh@...dia.com>, Juri Lelli <juri.lelli@...hat.com>
Cc: Christian Loehle <christian.loehle@....com>,
 Thierry Reding <treding@...dia.com>, Waiman Long <longman@...hat.com>,
 Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
 Michal Koutny <mkoutny@...e.com>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Phil Auld <pauld@...hat.com>, Qais Yousef <qyousef@...alina.io>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 "Joel Fernandes (Google)" <joel@...lfernandes.org>,
 Suleiman Souhlal <suleiman@...gle.com>, Aashish Sharma <shraash@...gle.com>,
 Shin Kawamura <kawasin@...gle.com>,
 Vineeth Remanan Pillai <vineeth@...byteword.org>,
 linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
 "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 3/2] sched/deadline: Check bandwidth overflow earlier
 for hotplug

On 21/02/2025 12:56, Jon Hunter wrote:
> 
> On 20/02/2025 15:25, Juri Lelli wrote:
>> On 20/02/25 11:40, Juri Lelli wrote:
>>> On 19/02/25 19:14, Dietmar Eggemann wrote:

[...]

> Latest branch is not building for me ...
> 
>   CC      kernel/time/hrtimer.o
> In file included from kernel/sched/build_utility.c:88:
> kernel/sched/topology.c: In function ‘partition_sched_domains’:
> kernel/sched/topology.c:2817:9: error: implicit declaration of function
> ‘dl_rebuild_rd_accounting’ [-Werror=implicit-function-declaration]
>  2817 |         dl_rebuild_rd_accounting();
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~

This should fix it for now:

-->8--

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 52243dcc61ab..3484dda93a94 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -954,7 +954,9 @@ static void dl_update_tasks_root_domain(struct cpuset *cs)
        css_task_iter_end(&it);
 }
 
-static void dl_rebuild_rd_accounting(void)
+extern void dl_rebuild_rd_accounting(void);
+
+void dl_rebuild_rd_accounting(void)
 {
        struct cpuset *cs = NULL;
        struct cgroup_subsys_state *pos_css;
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 9892e6fa3e57..60c9996ccf47 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -2806,6 +2806,8 @@ void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
        update_sched_domain_debugfs();
 }
 
+extern void dl_rebuild_rd_accounting(void);
+
 /*
  * Call with hotplug lock held
  */