linux-kernel - Re: [PATCH v7] Bluetooth: Fix possible race with userspace of sysfs isoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADg1FFeyN3AWYBD6UxOYGKfUaStyvVKVhuAzVtG_oCpXVdQnMg@mail.gmail.com>
Date: Sat, 22 Feb 2025 13:44:11 +0800
From: Hsin-chen Chuang <chharry@...gle.com>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, linux-bluetooth@...r.kernel.org, 
	chromeos-bluetooth-upstreaming@...omium.org, 
	Hsin-chen Chuang <chharry@...omium.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Johan Hedberg <johan.hedberg@...il.com>, Marcel Holtmann <marcel@...tmann.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Ying Hsu <yinghsu@...omium.org>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v7] Bluetooth: Fix possible race with userspace of sysfs isoc_alt

Hi Luiz,

On Sat, Feb 22, 2025 at 12:21 AM Luiz Augusto von Dentz
<luiz.dentz@...il.com> wrote:
>
> Hi Hsin-chen,
>
> On Fri, Feb 21, 2025 at 12:57 AM Hsin-chen Chuang <chharry@...gle.com> wrote:
> >
> > On Fri, Feb 21, 2025 at 1:47 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Fri, Feb 21, 2025 at 09:42:16AM +0800, Hsin-chen Chuang wrote:
> > > > On Wed, Feb 19, 2025 at 10:03 PM Hsin-chen Chuang <chharry@...gle.com> wrote:
> > >
> > > <snip>
> > >
> > > > Hi Luiz and Greg,
> > > >
> > > > Friendly ping for review, thanks.
> > >
> > > A review in less than 2 days?  Please be reasonable here, remember, many
> > > of us get 1000+ emails a day to deal with.
> > >
> > > To help reduce our load, take the time and review other patches on the
> > > mailing lists.  You are doing that, right?  If not, why not?
> > >
> > > patience please.
> > >
> > > greg k-h
> >
> > Got it. Take your time and thank you
>
> So it is not really possible to change the alt-setting any other way?
> I'm really at odds with adding something to sysfs that only one distro
> cares about, at very least that shall be put behind a Kconfig or as a
> module parameter, or perhaps we start to intercept the likes of

I'm willing to put this API behind a module parameter if that resolves
your concerns.

> HCI_EV_SYNC_CONN_COMPLETE when USER_CHANNEL and then check if
> alt_setting needs to be changed based on the air mode, how about that?

This is a good idea. Let me verify it and get back to you. Thanks.

-- 
Best Regards,
Hsin-chen