linux-kernel - Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250222061043.GW16911@sventech.com>
Date: Fri, 21 Feb 2025 22:10:43 -0800
From: Johannes Erdfelt <johannes@...felt.com>
To: Heiko Stübner <heiko@...ech.de>
Cc: Jianfeng Liu <liujianfeng1994@...il.com>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	simona@...ll.ch, devicetree@...r.kernel.org, conor+dt@...nel.org,
	robh@...nel.org, maarten.lankhorst@...ux.intel.com,
	hjc@...k-chips.com, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	mripard@...nel.org, tzimmermann@...e.de, andy.yan@...k-chips.com,
	krzk+dt@...nel.org, kernel@...labora.com, airlied@...il.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source
 to VOP2 on RK3588

On Tue, Feb 18, 2025, Heiko Stübner <heiko@...ech.de> wrote:
> I was more thinking about fixing the correct thing, with something like:
> 
> ----------- 8< ----------
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index cf7720b9172f..50faafbf5dda 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -5258,6 +5258,10 @@ of_clk_get_hw_from_clkspec(struct of_phandle_args *clkspec)
>         if (!clkspec)
>                 return ERR_PTR(-EINVAL);
> 
> +       /* Check if node in clkspec is in disabled/fail state */
> +       if (!of_device_is_available(clkspec->np))
> +               return ERR_PTR(-ENOENT);
> +
>         mutex_lock(&of_clk_mutex);
>         list_for_each_entry(provider, &of_clk_providers, link) {
>                 if (provider->node == clkspec->np) {
> ----------- 8< ----------
> 
> Because right now the clk framework does not handle nodes in
> failed/disabled state and would defer indefinitly.

I've been testing the recent patches Jimmy Hon has posted to add the
Orange Pi 5 Ultra DT and I ran into this bug. The Ultra uses HDMI1 for
the HDMI TX.

This patch successfully fixes the issue I was seeing.

JE