linux-kernel - Re: [PATCH v3 1/2] dt-bindings: can: fsl,flexcan: add transceiver capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250222072241.GA3458@debian>
Date: Sat, 22 Feb 2025 08:22:41 +0100
From: Dimitri Fedrau <dima.fedrau@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: dimitri.fedrau@...bherr.com, Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: can: fsl,flexcan: add transceiver
 capabilities

Am Fri, Feb 21, 2025 at 04:59:16PM +0000 schrieb Conor Dooley:
> On Fri, Feb 21, 2025 at 08:40:04AM +0100, Dimitri Fedrau via B4 Relay wrote:
> > From: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
> > 
> > Currently the flexcan driver does only support adding PHYs by using the
> > "old" regulator bindings. Add support for CAN transceivers as a PHY.
> > 
> > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
> > ---
> >  .../devicetree/bindings/net/can/fsl,flexcan.yaml          | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> > index 73252fe56fe6c8e9fd19142208bb655dc86d47cd..81125883cf86b9d19616bde378f74bdb6a32f1b2 100644
> > --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> > +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> > @@ -77,6 +77,9 @@ properties:
> >    xceiver-supply:
> >      description: Regulator that powers the CAN transceiver.
> >  
> > +  phys:
> > +    maxItems: 1
> > +
> >    big-endian:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description: |
> > @@ -171,6 +174,18 @@ allOf:
> >          interrupts:
> >            maxItems: 1
> >          interrupt-names: false
> > +  - if:
> > +      required:
> > +        - xceiver-supply
> > +    then:
> > +      properties:
> > +        phys: false
> > +  - if:
> > +      required:
> > +        - phys
> > +    then:
> > +      properties:
> > +        xceiver-supply: false
> 
> The duplication here is not needed, they both will cause errors in the
> same situation. With one dropped,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 

Thanks for your help, will drop one and sent out a V4.

Best regards,
Dimitri Fedrau