linux-kernel - Re: [PATCH v3 10/18] LoongArch: vDSO: Switch to generic storage implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afc16fdc2417c3a761b880950c6c03998366e92f.camel@xry111.site>
Date: Sat, 22 Feb 2025 16:20:51 +0800
From: Xi Ruoyao <xry111@...111.site>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Helge
 Deller <deller@....de>, Andy Lutomirski <luto@...nel.org>,  Thomas Gleixner
 <tglx@...utronix.de>, Vincenzo Frascino <vincenzo.frascino@....com>,
 Anna-Maria Behnsen	 <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>,  Andrew Morton <akpm@...ux-foundation.org>, Catalin
 Marinas <catalin.marinas@....com>, Will Deacon	 <will@...nel.org>, Theodore
 Ts'o <tytso@....edu>, "Jason A. Donenfeld"	 <Jason@...c4.com>, Paul
 Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt	 <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Huacai Chen	 <chenhuacai@...nel.org>,
 WANG Xuerui <kernel@...0n.name>, Russell King	 <linux@...linux.org.uk>,
 Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik	 <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Thomas
 Bogendoerfer	 <tsbogend@...ha.franken.de>, Michael Ellerman
 <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Christophe Leroy
 <christophe.leroy@...roup.eu>, Naveen N Rao	 <naveen@...nel.org>, Madhavan
 Srinivasan <maddy@...ux.ibm.com>, Ingo Molnar	 <mingo@...hat.com>, Borislav
 Petkov <bp@...en8.de>, Dave Hansen	 <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,  Arnd Bergmann	
 <arnd@...db.de>, Guo Ren <guoren@...nel.org>
Cc: linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-riscv@...ts.infradead.org, 
	loongarch@...ts.linux.dev, linux-s390@...r.kernel.org, 
	linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-arch@...r.kernel.org, Nam Cao <namcao@...utronix.de>, 
	linux-csky@...r.kernel.org
Subject: Re: [PATCH v3 10/18] LoongArch: vDSO: Switch to generic storage
 implementation

On Tue, 2025-02-04 at 13:05 +0100, Thomas Weißschuh wrote:
> The generic storage implementation provides the same features as the
> custom one. However it can be shared between architectures, making
> maintenance easier.
> 
> Co-developed-by: Nam Cao <namcao@...utronix.de>
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Tested-by: Xi Ruoyao <xry111@...111.site>

/* snip */

> diff --git a/arch/loongarch/include/asm/vdso/getrandom.h b/arch/loongarch/include/asm/vdso/getrandom.h
> index e80f3c4ac7481ba7f9f5d9210fefa78c3293243b..48c43f55b039b42168698614d0479b7a872d20f3 100644
> --- a/arch/loongarch/include/asm/vdso/getrandom.h
> +++ b/arch/loongarch/include/asm/vdso/getrandom.h

You can drop "#include <vdso/vdso.h>" in this file.

> @@ -28,11 +28,6 @@ static __always_inline ssize_t getrandom_syscall(void *_buffer, size_t _len, uns
>  	return ret;
>  }
>  
> -static __always_inline const struct vdso_rng_data *__arch_get_vdso_rng_data(void)
> -{
> -	return &_loongarch_data.rng_data;
> -}
> -
>  #endif /* !__ASSEMBLY__ */
>  
>  #endif /* __ASM_VDSO_GETRANDOM_H */

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University