linux-kernel - Re: [PATCH] Revert "i2c: core: Allocate temp client on the stack in i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7mZo7k3p1Po3hD5@shikoro>
Date: Sat, 22 Feb 2025 10:32:19 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Arnd Bergmann <arnd@...db.de>,
	Andi Shyti <andi.shyti@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Joe Hattori <joe@...is.s.u-tokyo.ac.jp>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Hans de Goede <hdegoede@...hat.com>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "i2c: core: Allocate temp client on the stack in
 i2c_detect"

On Fri, Feb 21, 2025 at 09:54:40PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> struct i2c_client is way too large to be put on the kernel stack, and depending
> on the kernel configuration, this can exceed the compile-time warning limit:
> 
> drivers/i2c/i2c-core-base.c:1420:12: error: stack frame size (1040) exceeds limit (1024) in 'i2c_do_add_adapter' [-Werror,-Wframe-larger-than]
>  1420 | static int i2c_do_add_adapter(struct i2c_driver *driver,
>       |            ^
> 
> The current version is the result of a cleanup patch that does not appear
> to be a requirement for anything else, so address the problem through a
> simple revert.
> 
> Fixes: 735668f8e5c9 ("i2c: core: Allocate temp client on the stack in i2c_detect")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you, yet Geert was faster and fixed a checkpatch check:

https://lore.kernel.org/r/f9aa39362e918b62aec0567f899b37d8d3c44710.1740064176.git.geert+renesas@glider.be


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)