linux-kernel - Re: [PATCH v4 0/2] Support for TI ADS7128 and ADS7138 ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250222115328.3208a0ce@jic23-huawei>
Date: Sat, 22 Feb 2025 11:53:28 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: "Sperling, Tobias" <Tobias.Sperling@...ting.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, "linux-iio@...r.kernel.org"
 <linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
 <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 0/2] Support for TI ADS7128 and ADS7138 ADCs

On Mon, 17 Feb 2025 14:56:53 +0000
"Sperling, Tobias" <Tobias.Sperling@...ting.com> wrote:

> > Von: Jonathan Cameron <jic23@...nel.org>
> > Gesendet: Sonntag, 16. Februar 2025 16:55
> >
> > On Thu, 13 Feb 2025 16:58:56 +0100
> > Tobias Sperling via B4 Relay <mailto:devnull+tobias.sperling.softing.com@...nel.org>
> > wrote:
> >   
> > > This patch series adds support for Texas Instruments ADS7128 and
> > > ADS7138, which are 12-bit, 8 channel analog-to-digital converters (ADCs)
> > > with build-in digital window comparator (DWC), using the I2C interface.
> > >
> > > The driver exposes the interfaces to read the raw values, as well as the
> > > minimum and maximum value for each channel. In addition several settings
> > > can be configured, like the DWC, sampling frequency or an averaging
> > > filter/oversampling. Interrupts triggered by the DWC, if configured, are
> > > then exposed as IIO events.
> > >
> > > ADS7128 differs in the addition of further hardware features, like a
> > > root-mean-square (RMS) and a zero-crossing-detect (ZCD) module, which
> > > are not yet supported by the driver.
> > >
> > > Regarding the I2C interface the chips using opcodes to define the way
> > > how the registeres are accessed, like single or multiple register(s)
> > > read/write or setting/clearing only bits.  
> > LGTM. Applied to the togreg branch of iio.git and pushed out initially
> > as testing for 0-day to take a look at it.
> > 
> > I did notice whilst applying that the Kconfig ordering for these TI parts
> > has gotten scrambled. So at some point we should clean that up and
> > bring them back into alphanumeric order!
> > 
> > Jonathan  
> 
> Ok, thanks for the info. Then everything is going its way I guess. :)
> 
> I can prepare a patch for the ordering. Shall this be based on top
> of this patch set or just the master branch?

This is a rare case where basing on my testing branch is the
best option.  Right now that matches togreg, but I'll probably be
applying some stuff on top today and that might touch this file.

Jonathan
> 
> Tobias