linux-kernel - Re: [PATCH 2/3] iio: imu: bmi270: rename variable bmi270

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250222173146.089ba66a@jic23-huawei>
Date: Sat, 22 Feb 2025 17:31:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Gustavo Silva <gustavograzs@...il.com>
Cc: Alex Lanzano <lanzano.alex@...il.com>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: imu: bmi270: rename variable bmi270_device to
 data

On Wed, 19 Feb 2025 20:54:46 -0300
Gustavo Silva <gustavograzs@...il.com> wrote:

> Rename all instances of 'struct bmi270_data' to 'data', to ensure
> consistency across the driver.
> 
> Signed-off-by: Gustavo Silva <gustavograzs@...il.com>
> ---
>  drivers/iio/imu/bmi270/bmi270_core.c | 79 ++++++++++++++++++------------------
>  1 file changed, 39 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index 9f24d4044ed6f00f67fd3a8f5adda821c3140a18..56ebd887fcec94b684dc23f1b4503b719fb39239 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -90,7 +90,7 @@ struct bmi270_data {
>  	struct {
>  		__le16 channels[6];
>  		aligned_s64 timestamp;
> -	} data __aligned(IIO_DMA_MINALIGN);
> +	} buffer __aligned(IIO_DMA_MINALIGN);
>  };
>  
>  enum bmi270_scan {
> @@ -284,7 +284,7 @@ static int bmi270_set_scale(struct bmi270_data *data, int chan_type, int uscale)
>  	return -EINVAL;
>  }
>  
> -static int bmi270_get_scale(struct bmi270_data *bmi270_device, int chan_type,
> +static int bmi270_get_scale(struct bmi270_data *data, int chan_type,
>  			    int *scale, int *uscale)
>  {
>  	int ret;
> @@ -293,7 +293,7 @@ static int bmi270_get_scale(struct bmi270_data *bmi270_device, int chan_type,
>  
>  	switch (chan_type) {
>  	case IIO_ACCEL:
> -		ret = regmap_read(bmi270_device->regmap,
> +		ret = regmap_read(data->regmap,
>  				  BMI270_ACC_CONF_RANGE_REG, &val);

Given shorter naming, a few places like this should be re line wrapped.

>  		if (ret)
>  			return ret;