linux-kernel - Re: [PATCH v7 4/6] media: platform: synopsys: Add support for HDMI input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dfb0ef63-8867-4d00-abdd-8280623c3405@collabora.com>
Date: Sun, 23 Feb 2025 00:25:18 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Dingxian Wen <shawn.wen@...k-chips.com>,
 Shreeya Patel <shreeya.patel@...labora.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 Heiko Stübner <heiko@...ech.de>,
 Jose Abreu <Jose.Abreu@...opsys.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nelson Costa <Nelson.Costa@...opsys.com>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Rob Herring <robh@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel@...labora.com,
 Tim Surber <me@...surber.de>
Subject: Re: [PATCH v7 4/6] media: platform: synopsys: Add support for HDMI
 input driver

On 2/19/25 23:56, Markus Elfring wrote:
> …
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> @@ -0,0 +1,2718 @@
> …
>> +static u32 hdmirx_readl(struct snps_hdmirx_dev *hdmirx_dev, int reg)
>> +{
>> +	u32 val;
>> +
>> +	guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);
>> +
>> +	val = readl(hdmirx_dev->regs + reg);
>> +
>> +	return val;
>> +}
> 
> May such a function implementation be simplified?
> 
> {
> 	guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);
> 	return readl(hdmirx_dev->regs + reg);
> }

That will work, thanks.

> …
>> +static int hdmirx_get_detected_timings(struct snps_hdmirx_dev *hdmirx_dev,
>> +				       struct v4l2_dv_timings *timings)
>> +{
> …
>> +	mutex_lock(&hdmirx_dev->work_lock);
>> +retry:
>> +	memset(timings, 0, sizeof(struct v4l2_dv_timings));
> …
>> +	mutex_unlock(&hdmirx_dev->work_lock);
>> +
>> +	return ret;
>> +}
> …
> 
> Would you become interested to apply a statement like “guard(mutex)(&hdmirx_dev->work_lock);”?
> https://elixir.bootlin.com/linux/v6.14-rc3/source/include/linux/mutex.h#L201

That will make code less consistent and less intuitive to me. Anyways,
thanks for the suggestion.

-- 
Best regards,
Dmitry