linux-kernel - Re: [PATCH v2 1/4] dt-bindings: clock: samsung,exynos990-clock: add PERIC0/1 clock management unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e190d51a-b585-4544-8154-b9a287f907be@kernel.org>
Date: Sun, 23 Feb 2025 11:19:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Denzeel Oliva <wachiturroxd150@...il.com>, s.nawrocki@...sung.com,
 cw00.choi@...sung.com, alim.akhtar@...sung.com, mturquette@...libre.com,
 sboyd@...nel.org, robh@...nel.org, conor+dt@...nel.org,
 andi.shyti@...nel.org, igor.belwon@...tallysanemainliners.org,
 linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: samsung,exynos990-clock: add
 PERIC0/1 clock management unit

On 12/02/2025 01:48, Denzeel Oliva wrote:
> Add dt-schema documentation for the Connectivity Peripheral 0 / 1
> (PERIC0/1) clock management unit.
> 
> Signed-off-by: Denzeel Oliva <wachiturroxd150@...il.com>
> ---
>  .../clock/samsung,exynos990-clock.yaml        |  24 +++
>  include/dt-bindings/clock/samsung,exynos990.h | 176 ++++++++++++++++++
>  2 files changed, 200 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> index c15cc1752..dd301deda 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> @@ -30,6 +30,8 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - samsung,exynos990-cmu-peric0
> +      - samsung,exynos990-cmu-peric1

Mismatched order.

>        - samsung,exynos990-cmu-hsi0
>        - samsung,exynos990-cmu-peris
>        - samsung,exynos990-cmu-top
> @@ -56,6 +58,28 @@ required:
>    - reg
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - samsung,exynos990-cmu-peric1
> +              - samsung,exynos990-cmu-peric0

These also reverse.  Keep things ordered alphabetically. Also this
if:then: block should go to appropriate place.


Best regards,
Krzysztof