linux-kernel - Re: [PATCH v8] sched: Consolidate cpufreq updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250223000351.xg53osxswsxxohye@airbuntu>
Date: Sun, 23 Feb 2025 00:03:51 +0000
From: Qais Yousef <qyousef@...alina.io>
To: Ingo Molnar <mingo@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Christian Loehle <christian.loehle@....com>,
	Hongyan Xia <hongyan.xia2@....com>,
	John Stultz <jstultz@...gle.com>, Anjali K <anjalik@...ux.ibm.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8] sched: Consolidate cpufreq updates

On 02/21/25 16:47, Ingo Molnar wrote:
> 
> * Qais Yousef <qyousef@...alina.io> wrote:
> 
> > ---
> >  include/linux/sched/cpufreq.h    |   4 +-
> >  kernel/sched/core.c              | 116 +++++++++++++++++++++++++++--
> >  kernel/sched/cpufreq_schedutil.c | 122 +++++++++++++++++++------------
> >  kernel/sched/deadline.c          |  10 ++-
> >  kernel/sched/fair.c              |  84 +++++++++------------
> >  kernel/sched/rt.c                |   8 +-
> >  kernel/sched/sched.h             |   9 ++-
> >  kernel/sched/syscalls.c          |  30 ++++++--
> >  8 files changed, 266 insertions(+), 117 deletions(-)
> 
> The changelog is rather long, and the diffstat is non-trivial.
> 
> Could you please split this up into multiple patches?

Sure. I did consider that but what stopped me is that I couldn't see how
I could break them into independent patches. A lot of corner cases needed to be
addressed and if I moved them to their own patches I'd potentially break
bisectability of this code. If this is not a problem then I can see how I can
do a better split. If it is a problem, I'll still try to think it over but it
might require a bit of stretching. But I admit I didn't try to think it over
that hard.

Thanks!

--
Qais Yousef