linux-kernel - Re: [PATCH V4] media: i2c: imx334: Add support for 1280x720 & 640x480 resolutions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7xj5JJe27L39wCG@kekkonen.localdomain>
Date: Mon, 24 Feb 2025 12:19:48 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Shravan.Chippa@...rochip.com
Cc: mchehab@...nel.org, kieran.bingham@...asonboard.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Conor.Dooley@...rochip.com, Valentina.FernandezAlanis@...rochip.com,
	Praveen.Kumar@...rochip.com
Subject: Re: [PATCH V4] media: i2c: imx334: Add support for 1280x720 &
 640x480 resolutions

Hi Shravan,

On Mon, Feb 24, 2025 at 11:07:58AM +0000, Shravan.Chippa@...rochip.com wrote:
> > > > Please split this into two to make it more reviewable: splitting
> > > > register lists into two and then to adding new modes.
> > >
> > > I will try to make one patch for common register values One more patch
> > > for new modes of 640x480 and 1280x720
> > 
> > Please add one for the hblank changes and more if there are similar cases.
> 
> Date sheet is not clear to me to understand the horizontal blank change value dynamically.
> And do not have proper equipment (hardware) to measure horizontal blank values by change the register values.

Ok, fair enough. Maybe it'd be better to leave it as-is if there's no need
to change it? Many Omnivision sensors use some other, non-line/pixel based
unit for blankings indeed.

-- 
Regards,

Sakari Ailus