linux-kernel - Re: [RESEND PATCH] powerpc: mpic: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f872c2ef-4adc-4daa-aa12-769e3108abc8@csgroup.eu>
Date: Mon, 24 Feb 2025 13:56:53 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Ricardo B. Marlière
 <ricardo@...liere.net>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] powerpc: mpic: Use str_enabled_disabled() helper
 function

Hi,

Le 19/02/2025 à 12:20, Thorsten Blum a écrit :
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
> warning.
> 
> Reviewed-by: Ricardo B. Marlière <ricardo@...liere.net>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---

When you resend a patch, please tell why here (below the ---) so that we 
know the reason.

At the time being I have several duplicated patches from you and I don't 
know what to do with them which one to keep and which one to drop.

The list is here:

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400

>   arch/powerpc/sysdev/mpic.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index d94cf36b0f65..25fc4ac91814 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -27,6 +27,7 @@
>   #include <linux/spinlock.h>
>   #include <linux/pci.h>
>   #include <linux/slab.h>
> +#include <linux/string_choices.h>
>   #include <linux/syscore_ops.h>
>   #include <linux/ratelimit.h>
>   #include <linux/pgtable.h>
> @@ -474,9 +475,9 @@ static void __init mpic_scan_ht_msi(struct mpic *mpic, u8 __iomem *devbase,
>   		addr = addr | ((u64)readl(base + HT_MSI_ADDR_HI) << 32);
>   	}
>   
> -	printk(KERN_DEBUG "mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> -		PCI_SLOT(devfn), PCI_FUNC(devfn),
> -		flags & HT_MSI_FLAGS_ENABLE ? "enabled" : "disabled", addr);
> +	pr_debug("mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> +		 PCI_SLOT(devfn), PCI_FUNC(devfn),
> +		 str_enabled_disabled(flags & HT_MSI_FLAGS_ENABLE), addr);
>   
>   	if (!(flags & HT_MSI_FLAGS_ENABLE))
>   		writeb(flags | HT_MSI_FLAGS_ENABLE, base + HT_MSI_FLAGS);