linux-kernel - Re: [PATCH v14 0/3] Add support for AMD MDB IP as Root Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7x2ZLOiNK4cBCp2@ryzen>
Date: Mon, 24 Feb 2025 14:38:44 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@....com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	manivannan.sadhasivam@...aro.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	michal.simek@....com, bharat.kumar.gogada@....com,
	jingoohan1@...il.com
Subject: Re: [PATCH v14 0/3] Add support for AMD MDB IP as Root Port

On Mon, Feb 24, 2025 at 01:01:14PM +0530, Thippeswamy Havalige wrote:
> This series of patch add support for AMD MDB IP as Root Port.
> 
> The AMD MDB IP support's 32 bit and 64bit BAR's at Gen5 speed.

Which PCIe controller does not support 64-bit BARs?

Seems like quite a random sentence IMO.

> As Root Port it supports MSI and legacy interrupts.

You are not submitting Endpoint mode support for your controller,
so it seems a bit weird to talk about "As Root Port ...".

Your patch only includes Root Complex mode, and makes no reference
to Endpoint mode anywhere, so perhaps just state that the controller
supports MSI and INTx interrupts.

Kind regards,
Niklas