linux-kernel - Re: [PATCH v7 2/6] rust: str: implement `Index` for `BStr`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y0xvpi2s.fsf@kloenk.dev>
Date: Mon, 24 Feb 2025 14:50:51 +0100
From: Fiona Behrens <me@...enk.dev>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>,  Alex Gaynor <alex.gaynor@...il.com>,
  Boqun Feng <boqun.feng@...il.com>,  Gary Guo <gary@...yguo.net>,
  Björn
 Roy Baron <bjorn3_gh@...tonmail.com>,  Benno Lossin
 <benno.lossin@...ton.me>,  Alice Ryhl <aliceryhl@...gle.com>,  Trevor
 Gross <tmgross@...ch.edu>,  Masahiro Yamada <masahiroy@...nel.org>,
  Nathan Chancellor <nathan@...nel.org>,  Nicolas Schier
 <nicolas@...sle.eu>,  Luis Chamberlain <mcgrof@...nel.org>,
  rust-for-linux@...r.kernel.org,  linux-kernel@...r.kernel.org,  Adam
 Bratschi-Kaye <ark.email@...il.com>,  linux-kbuild@...r.kernel.org,  Petr
 Pavlu <petr.pavlu@...e.com>,  Sami Tolvanen <samitolvanen@...gle.com>,
  Daniel Gomez <da.gomez@...sung.com>,  Simona Vetter
 <simona.vetter@...ll.ch>,  Greg KH <gregkh@...uxfoundation.org>,
  linux-modules@...r.kernel.org
Subject: Re: [PATCH v7 2/6] rust: str: implement `Index` for `BStr`

Andreas Hindborg <a.hindborg@...nel.org> writes:

> The `Index` implementation on `BStr` was lost when we switched `BStr` from
> a type alias of `[u8]` to a newtype. This patch adds back `Index` by
> implementing `Index` for `BStr` when `Index` would be implemented for
> `[u8]`.
>
> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>

Reviewed-by: Fiona Behrens <me@...enk.dev>

> ---
>  rust/kernel/str.rs | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs
> index 002dcddf7c768..ba6b1a5c4f99d 100644
> --- a/rust/kernel/str.rs
> +++ b/rust/kernel/str.rs
> @@ -114,6 +114,17 @@ fn eq(&self, other: &Self) -> bool {
>      }
>  }
>  
> +impl<Idx> Index<Idx> for BStr
> +where
> +    [u8]: Index<Idx, Output = [u8]>,
> +{
> +    type Output = Self;
> +
> +    fn index(&self, index: Idx) -> &Self::Output {
> +        BStr::from_bytes(&self.0[index])
> +    }
> +}
> +
>  /// Creates a new [`BStr`] from a string literal.
>  ///
>  /// `b_str!` converts the supplied string literal to byte string, so non-ASCII