linux-kernel - Re: [PATCH 1/2] mm, cma: fix 32-bit warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d90ca138-7506-4d1c-b144-08b6099ee63c@redhat.com>
Date: Mon, 24 Feb 2025 15:36:28 +0100
From: David Hildenbrand <david@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, Nathan Chancellor <nathan@...nel.org>,
 Frank van der Linden <fvdl@...gle.com>
Cc: Arnd Bergmann <arnd@...db.de>,
 Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
 Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 Zi Yan <ziy@...dia.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 llvm@...ts.linux.dev
Subject: Re: [PATCH 1/2] mm, cma: fix 32-bit warning

On 24.02.25 15:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> clang warns about certain always-true conditions, like this one on 32-bit
> builds:
> 
> mm/cma.c:420:13: error: result of comparison of constant 4294967296 with expression of type 'phys_addr_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare]
>    420 |                 if (start < SZ_4G)
>        |                     ~~~~~ ^ ~~~~~
> 

Hm, so in this case the whole loop is unnecessary.

In any case

Acked-by: David Hildenbrand <david@...hat.com>


-- 
Cheers,

David / dhildenb