linux-kernel - Re: [PATCH 5/5] arm64: dts: mba8mx: change sound card model name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6132446.lOV4Wx5bFT@steina-w>
Date: Mon, 24 Feb 2025 16:01:46 +0100
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Shawn Guo <shawnguo2@...h.net>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Markus Niebel <Markus.Niebel@...tq-group.com>, linux@...tq-group.com,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: mba8mx: change sound card model name

Hi Shawn,

Am Samstag, 22. Februar 2025, 10:09:39 CET schrieb Shawn Guo:
> On Mon, Jan 20, 2025 at 02:25:02PM +0100, Alexander Stein wrote:
> > From: Markus Niebel <Markus.Niebel@...tq-group.com>
> > 
> > The card name for ALSA is generated from the model name string and
> > is limited to 16 characters. Use a shorter name to prevent cutting the
> > name.
> > 
> > Since nearly all starter kit mainboards for i.MX based SoM by TQ-Systems
> > use the same codec with the same routing on board it is a good idea to
> > use the same mode name for the sound card. This allows sharing a default
> > asound.conf in BSP over all the kits.
> > 
> > Signed-off-by: Markus Niebel <Markus.Niebel@...tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> 
> I may have missed some prerequisite ones, but #4 and #5 do not apply for
> me.

Thanks for pointing out. A local commit was silently introduced as dependency.
I removed it and pushed a v2 while also fixing a typo in the commit message
'mode' -> 'model'

Thanks
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/