linux-kernel - Re: [PATCH 2/6] dt-bindings: gpio: add max77759 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224153858.GC3137990-robh@kernel.org>
Date: Mon, 24 Feb 2025 09:38:58 -0600
From: Rob Herring <robh@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Peter Griffin <peter.griffin@...aro.org>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: gpio: add max77759 binding

On Mon, Feb 24, 2025 at 10:28:50AM +0000, André Draszik wrote:
> Add the DT binding document for the GPIO module of the Maxim MAX77759.
> 
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> ---
>  .../bindings/gpio/maxim,max77759-gpio.yaml         | 47 ++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml
> new file mode 100644
> index 000000000000..9bafb16ad688
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/maxim,max77759-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX77759 GPIO
> +
> +maintainers:
> +  - André Draszik <andre.draszik@...aro.org>
> +
> +description: |
> +  This module is part of the MAX77759 PMIC. For additional information, see
> +  Documentation/devicetree/bindings/mfd/maxim,max77759.yaml.
> +
> +  The MAX77759 is a PMIC integrating, amongst others, a GPIO controller
> +  including interrupt support for 2 GPIO lines.
> +
> +properties:
> +  compatible:
> +    const: maxim,max77759-gpio
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  interrupt-controller: true
> +
> +  interrupts:
> +    maxItems: 2

You need to define what each interrupt is.

> +
> +  "#gpio-cells":
> +    const: 2
> +
> +  gpio-controller: true
> +
> +  gpio-line-names:
> +    minItems: 1
> +    maxItems: 2
> +
> +required:
> +  - compatible
> +  - "#gpio-cells"
> +  - gpio-controller
> +  - "#interrupt-cells"
> +  - interrupt-controller
> +
> +additionalProperties: false
> 
> -- 
> 2.48.1.658.g4767266eb4-goog
>