linux-kernel - Re: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6130937.lOV4Wx5bFT@workhorse>
Date: Mon, 24 Feb 2025 17:09:36 +0100
From: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>, Mark Brown <broonie@...nel.org>
Cc: kernel@...labora.com, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes

On Monday, 24 February 2025 16:42:08 Central European Standard Time Mark Brown 
wrote:
> On Mon, Feb 24, 2025 at 04:33:11PM +0100, Luca Ceresoli wrote:
> > Hello Nicolas,
> > 
> > +Cc: Mark Brown
> > 
> > On Fri, 21 Feb 2025 21:39:32 +0100
> > 
> > Nicolas Frattaroli <nicolas.frattaroli@...labora.com> wrote:
> > > Some tools like KGraphViewer interpret the "ON" nodes not having an
> > > explicitly set fill colour as them being entirely black, which obscures
> > > the text on them and looks funny. In fact, I thought they were off for
> > > the longest time. Comparing to the output of the `dot` tool, I assume
> > > they are supposed to be white.
> 
> As documented in submitting-patches.rst please send patches to the
> maintainers for the code you would like to change.  The normal kernel
> workflow is that people apply patches from their inboxes, if they aren't
> copied they are likely to not see the patch at all and it is much more
> difficult to apply patches.

Hi Mark,

I used b4 to submit the patch, which runs get-maintainer when I run b4 prep --
auto-to-cc. You can see that even running get_maintainer manually for this 
file, you're not one of the recipients:

 ./scripts/get_maintainer.pl -f tools/sound/dapm-graph
 Luca Ceresoli <luca.ceresoli@...tlin.com> (maintainer:SOUND - SOC LAYER / 
dapm-graph)
 linux-sound@...r.kernel.org (open list:SOUND - SOC LAYER / dapm-graph)
 linux-kernel@...r.kernel.org (open list)

It looks like you're not listed as a maintainer of this file or a parent tree 
in the MAINTAINERS file, which would explain the discrepancy.

Regards,
Nicolas Frattaroli