linux-kernel - Re: [PATCH] net: wangxun: fix LIBWX dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <451d4cfe-b22f-4ac5-9074-05a2155f7d6a@linux.dev>
Date: Mon, 24 Feb 2025 16:05:43 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Jiawen Wu <jiawenwu@...stnetic.com>,
 Mengyuan Lou <mengyuanlou@...-swift.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
 Andi Shyti <andi.shyti@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wangxun: fix LIBWX dependencies

On 24/02/2025 14:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Selecting LIBWX requires that its dependencies are met first:
> 
> WARNING: unmet direct dependencies detected for LIBWX
>    Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
>    Selected by [y]:
>    - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] && COMMON_CLK [=y] && I2C_DESIGNWARE_PLATFORM [=y]
> ld.lld-21: error: undefined symbol: ptp_schedule_worker
>>>> referenced by wx_ptp.c:747 (/home/arnd/arm-soc/drivers/net/ethernet/wangxun/libwx/wx_ptp.c:747)
>>>>                drivers/net/ethernet/wangxun/libwx/wx_ptp.o:(wx_ptp_reset) in archive vmlinux.a
> 
> Add the smae dependency on PTP_1588_CLOCK_OPTIONAL to the two driver
> using this library module.
> 
> Fixes: 06e75161b9d4 ("net: wangxun: Add support for PTP clock")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/net/ethernet/wangxun/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index 6b60173fe1f5..47e3e8434b9e 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -26,6 +26,7 @@ config LIBWX
>   config NGBE
>   	tristate "Wangxun(R) GbE PCI Express adapters support"
>   	depends on PCI
> +	depends on PTP_1588_CLOCK_OPTIONAL
>   	select LIBWX
>   	select PHYLINK
>   	help
> @@ -43,6 +44,7 @@ config TXGBE
>   	depends on PCI
>   	depends on COMMON_CLK
>   	depends on I2C_DESIGNWARE_PLATFORM
> +	depends on PTP_1588_CLOCK_OPTIONAL
>   	select MARVELL_10G_PHY
>   	select REGMAP
>   	select PHYLINK

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>