linux-kernel - Re: [PATCH v4 0/3] drm/amd/display: Stop control flow if the divisior is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H4giTorYbo4uL_KNL1MmHWfWKX8EnhKdC_Yz0_sX17PvA@mail.gmail.com>
Date: Mon, 24 Feb 2025 12:48:59 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Nathan Chancellor <nathan@...nel.org>, 
	Josh Poimboeuf <jpoimboe@...nel.org>, Peter Zijlstra <peterz@...radead.org>, loongarch@...ts.linux.dev, 
	amd-gfx@...ts.freedesktop.org, llvm@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/3] drm/amd/display: Stop control flow if the divisior
 is zero

On Tue, Jan 14, 2025 at 9:29 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> As far as I can tell, with the current existing macro definitions, there
> is no better way to do the minimal and proper changes to stop the control
> flow if the divisior is zero.
>
> In order to keep the current ability for the aim of debugging and avoid
> printing the warning message twice, it is better to only use ASSERT_BUG()
> and SPL_ASSERT_BUG() directly after doing the following two steps:
>
> (1) Add ASSERT_BUG() macro definition
> (2) Add SPL_ASSERT_BUG() macro definition
>
> This version is based on 6.13-rc7, tested on x86 and LoongArch.
Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>

>
> Tiezhu Yang (3):
>   drm/amd/display: Add ASSERT_BUG() macro definition
>   drm/amd/display: Add SPL_ASSERT_BUG() macro definition
>   drm/amd/display: Harden callers of division functions
>
>  drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c  |  2 +-
>  drivers/gpu/drm/amd/display/dc/os_types.h           |  7 +++++++
>  drivers/gpu/drm/amd/display/dc/spl/spl_debug.h      | 11 +++++++++++
>  drivers/gpu/drm/amd/display/dc/spl/spl_fixpt31_32.c |  2 +-
>  4 files changed, 20 insertions(+), 2 deletions(-)
>
> --
> 2.42.0
>
>