linux-kernel - Re: [PATCH v2] auxdisplay: hd44780: Fix potential memory leak in hd44780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z7ytRJMHOqftODD8@smile.fi.intel.com>
Date: Mon, 24 Feb 2025 19:32:52 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jianglei Nie <niejianglei2021@....com>
Cc: ojeda@...nel.org, geert+renesas@...der.be, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix potential memory leak in
 hd44780_remove()

On Mon, Nov 28, 2022 at 12:59:28PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 28, 2022 at 12:45:39PM +0200, Andy Shevchenko wrote:
> > On Mon, Nov 28, 2022 at 04:44:21PM +0800, Jianglei Nie wrote:

...

> > Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> > 
> > What you found has nothing to do with the issue. Issue has been introduced
> > later on.
> 
> Side note (mostly for Miguel): That series by Lars was indeed problematic.
> And I see now that he didn't get the parameter to the charlcd_alloc(). Now
> we have problem that your patch solves and dangling parameter in the struct
> charlcd_priv. So, I will restore charlcd_alloc() before his series (after
> this patch has been applied, because of the backport needs) for a new
> kernel development cycle.

FWIW, the
https://lore.kernel.org/r/20250224173010.219024-1-andriy.shevchenko@linux.intel.com
has been just sent.

-- 
With Best Regards,
Andy Shevchenko