linux-kernel - Re: [PATCH v2 1/6] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250224173736.GA3566877-robh@kernel.org>
Date: Mon, 24 Feb 2025 11:37:36 -0600
From: Rob Herring <robh@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Stanislav Jakubek <stano.jakubek@...il.com>,
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 1/6] dt-bindings: pinctrl: Add bindings for BCM21664
 pin controller

On Fri, Feb 21, 2025 at 09:37:48PM +0100, Artur Weber wrote:
> On 21.02.2025 21:32, Artur Weber wrote:
> > Add device tree bindings for the pin controller included in the
> > BCM21664 chip. The bindings are based off brcm,bcm11351-pinctrl.yaml;
> > both chips use the same driver, but have different pins, and the
> > BCM21664 has 6 alt modes instead of 4.
> > 
> > Signed-off-by: Artur Weber <aweber.kernel@...il.com>
> > ---
> > (...)
> > +examples:
> > +  - |
> > +    pinctrl@...04800 {
> > +      compatible = "brcm,bcm21664-pinctrl";
> > +      reg = <0x35004800 0x7f0>;
> > +
> > +      dev-a-active-pins {
> > +        /* group node defining 1 standard pin */
> > +        std-grp0 {
> > +          pins = "gpio00";
> > +          function = "alt1";
> > +          input-schmitt-enable;
> > +          bias-disable;
> > +          slew-rate = <1>;
> > +          drive-strength = <4>;
> > +        };
> > +
> > +        /* group node defining 2 I2C pins */
> > +        i2c-grp0 {
> > +          pins = "bsc1clk", "bsc1dat";
> > +          function = "alt2";
> > +          bias-pull-up = <720>;
> > +          input-enable;
> 
> bias-pull-up should not have a value (pull up strength is not
> supported). Will fix this in the next version.

Please make the schema enforce that, not just fix the example.

Rob