linux-kernel - Re: [PATCH] samples/damon: a typo in the kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250224190145.24272-1-sj@kernel.org>
Date: Mon, 24 Feb 2025 11:01:45 -0800
From: SeongJae Park <sj@...nel.org>
To: bus710 <bus710@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples/damon: a typo in the kconfig - sameple

Hi bus710,

On Mon, 24 Feb 2025 10:07:09 -0800 bus710 <bus710@...il.com> wrote:

> Signed-off-by: bus710 <bus710@...il.com>

Reviewed-by: SeongJae Park <sj@...nel.org>

Thank you for this fix!

> ---
> Hi SeongJae Park, 
> 
> I found a trivial typo in the Kconfig file of the damon sample module
> while I was trying to do some experiments with sample codes.
> The word "sameple" should be "sample", I believe. Please find the diff below.

I think the above sentence is better to be added to the "Explanation Body"[1]
part of this patch.  This shouldn't be a blocker of this patch though, since it
is very simple.  Please consider doing so if you have a chance to send another
patch in future, though.

> 
> Since the title should follow the format of the project, I sent a new
> email to the mailing list. Sorry for the inconvenience.
> 
> Thanks for the interesting project! DAMON will be very useful for many
> projects.
> 
> Thanks,
> 
> Ps: I found I didn't change the subject! Sorry this is my very first
> communication with the project.

No worry, everyone makes mistakes, like I made the typo! ;)  Thank you for
finding and fixing mine!

[1] https://docs.kernel.org/process/submitting-patches.html#explanation-body


Thanks,
SJ

> 
> 
>  samples/damon/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/damon/Kconfig b/samples/damon/Kconfig
> index 63f6dcd71daa..564c49ed69a2 100644
> --- a/samples/damon/Kconfig
> +++ b/samples/damon/Kconfig
> @@ -3,7 +3,7 @@
>  menu "DAMON Samples"
>  
>  config SAMPLE_DAMON_WSSE
> -	bool "DAMON sameple module for working set size estimation"
> +	bool "DAMON sample module for working set size estimation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for working set size estimation.
> @@ -15,7 +15,7 @@ config SAMPLE_DAMON_WSSE
>  	  If unsure, say N.
>  
>  config SAMPLE_DAMON_PRCL
> -	bool "DAMON sameple module for access-aware proactive reclamation"
> +	bool "DAMON sample module for access-aware proactive reclamation"
>  	depends on DAMON && DAMON_VADDR
>  	help
>  	  This builds DAMON sample module for access-aware proactive
> -- 
> 2.47.2