linux-kernel - Re: [PATCH v6 2/7] selftests: x86: test_mremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502241102.AB138D32C5@keescook>
Date: Mon, 24 Feb 2025 11:02:51 -0800
From: Kees Cook <kees@...nel.org>
To: jeffxu@...omium.org
Cc: akpm@...ux-foundation.org, jannh@...gle.com,
	torvalds@...ux-foundation.org, vbabka@...e.cz,
	lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
	adhemerval.zanella@...aro.org, oleg@...hat.com, avagin@...il.com,
	benjamin@...solutions.net, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org, linux-mm@...ck.org,
	jorgelo@...omium.org, sroettger@...gle.com, hch@....de,
	ojeda@...nel.org, thomas.weissschuh@...utronix.de,
	adobriyan@...il.com, johannes@...solutions.net,
	pedro.falcato@...il.com, hca@...ux.ibm.com, willy@...radead.org,
	anna-maria@...utronix.de, mark.rutland@....com,
	linus.walleij@...aro.org, Jason@...c4.com, deller@....de,
	rdunlap@...radead.org, davem@...emloft.net, peterx@...hat.com,
	f.fainelli@...il.com, gerg@...nel.org, dave.hansen@...ux.intel.com,
	mingo@...nel.org, ardb@...nel.org, mhocko@...e.com,
	42.hyeyoo@...il.com, peterz@...radead.org, ardb@...gle.com,
	enh@...gle.com, rientjes@...gle.com, groeck@...omium.org,
	mpe@...erman.id.au, aleksandr.mikhalitsyn@...onical.com,
	mike.rapoport@...il.com
Subject: Re: [PATCH v6 2/7] selftests: x86: test_mremap_vdso: skip if vdso is
 msealed

On Mon, Feb 24, 2025 at 05:45:08PM +0000, jeffxu@...omium.org wrote:
> From: Jeff Xu <jeffxu@...omium.org>
> 
> Add code to detect if the vdso is memory sealed, skip the test
> if it is.
> 
> Signed-off-by: Jeff Xu <jeffxu@...omium.org>

Thanks, after my full 360 on reading this code, I'm back to where I was
originally: it looks good to me. :)

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook