linux-kernel - Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224192105.GA48-beaub@linux.microsoft.com>
Date: Mon, 24 Feb 2025 19:21:26 +0000
From: Beau Belgrave <beaub@...ux.microsoft.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Shuah Khan <skhan@...uxfoundation.org>, realxxyq@....com,
	shuah@...nel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org, Yiqian Xun <xunyiqian@...inos.cn>
Subject: Re: [PATCH v1] selftests/user_events: Fix failures caused by test
 code

On Fri, Feb 21, 2025 at 12:28:42PM -0500, Steven Rostedt wrote:
> On Fri, 21 Feb 2025 08:46:31 -0700
> Shuah Khan <skhan@...uxfoundation.org> wrote:
> 
> > On 2/20/25 20:35, realxxyq@....com wrote:
> > > From: Yiqian Xun <xunyiqian@...inos.cn>
> > > 
> > > In parse_abi function,the dyn_test fails because the
> > > enable_file isn’t closed after successfully registering an event.
> > > By adding wait_for_delete(), the dyn_test now passes as expected.
> > > 
> > > Signed-off-by: Yiqian Xun <xunyiqian@...inos.cn>
> > > ---
> > >   tools/testing/selftests/user_events/dyn_test.c | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing/selftests/user_events/dyn_test.c
> > > index bdf9ab127488..54c9412f8dee 100644
> > > --- a/tools/testing/selftests/user_events/dyn_test.c
> > > +++ b/tools/testing/selftests/user_events/dyn_test.c
> > > @@ -127,6 +127,8 @@ static int parse_abi(int *check, const char *value)
> > >   
> > >   	close(fd);
> > >   
> > > +	wait_for_delete();
> > > +
> > >   	return ret;
> > >   }
> > >     
> > 

Thank you for this fix!

> > Adding Steve for review.
> > 
> > Steve, please review the patch. If you are happy with it
> > give me Ack or Reviewed-by if you want to take this through
> > my tree.
> 
> Actually, Beau should review it.
> 
> Beau?
> 

I applied it locally and ensured it passed (seems timing related).

Acked-by: Beau Belgrave <beaub@...ux.microsoft.com>

-Beau

> Here's the patch: https://lore.kernel.org/all/20250221033555.326716-1-realxxyq@163.com/
> 
> -- Steve
> 
>